The JavaScript used to move inline messages should use Drupal.behaviors instead of $(document).ready(). See http://drupal.org/node/304258 for a detailed explanation of why this is important.

The short version is:
* It is a Drupal standard.
* Messages won't be moved inline if they are inserted into the page asynchronously.

I've attached a patch that fixes this. It also fixes a few other problems with the JavaScript. The main problem was that the code seemed to be mixing PHP and JavaScript. For example, declaring variables like this:

$form_id = $('form#' + Drupal.settings.form_submitted);

instead of like this:

var form_id = $('form#' + Drupal.settings.form_submitted);

CommentFileSizeAuthor
javascript_behaviors.patch1.95 KBjtsnow

Comments

ain’s picture

ain commented

I do disagree Re mixing PHP with JavaScript. I use the exact same convention in jQuery in such circumstances and I believe it's completely fine.

jtsnow’s picture

jtsnow commented

Yes, I have since learned that prefixing JavaScript variables with a dollar sign is a convention for naming variables that contain Drupal objects. The Drupal JavaScript coding standards do not specify a preference on this and some code in Drupal 7 core follows the convention, so it is legitimate.

However, the coding standards do say "All variables should be declared with var before they are used and should only be declared once. "

jtsnow’s picture

jtsnow commented

Yes, I have since learned that prefixing JavaScript variables with a dollar sign is a convention for naming variables that contain Drupal objects. The Drupal JavaScript coding standards do not specify a preference on this and some code in Drupal 7 core follows the convention, so it is legitimate.

However, the coding standards do say "All variables should be declared with var before they are used and should only be declared once. "

jtsnow’s picture

jtsnow commented
Issue summary: View changes

Updating documentation link.