The Webform module prevents certain components from having their title display option set to "inline", but the same restrictions aren't enforced by the Form Builder integration module.
The effect is that with Form Builder you can configure e.g. a textarea to have its title display inline, which doesn't work (and which breaks resizable textareas too).
This patch makes it so that the correct options are shown for the title display. It also adds the correct title display options to fieldsets (which previously did not allow you to configure the title display at all, even though you should at least be able to mark the title hidden).
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | form-builder-webform-title-display-inline-1223880-2.patch | 1.9 KB | David_Rothstein |
| form-builder-webform-title-display-inline.patch | 2.99 KB | David_Rothstein |
Comments
Comment #1
quicksketchFantastic, thanks David.
Comment #2
David_Rothstein commentedHm, it turns out that the title display setting on fieldsets doesn't work correctly with this patch. I think it's because Webform handles title displays in a special way for fieldsets, but haven't had time to actually track it down.
So here's a new patch that removes that part; it's kind of a separate issue anyway, and the rest of the patch works well as is.
Comment #3
bowersox commentedsub
Comment #4
quicksketchAlthough Webform utilizes the core #title_display option, I think this might be a good situation to just pull the form directly from Webform, the same way that we pull options for some of the more advanced webform components. Then components can provide their own title display options. This deep property checking seems very likely to break in the future.
Comment #5
quicksketchAh well, for now we'll go with this. Committed.
Comment #6
quicksketchThis patch has been rolled back due to the new approach in #1405858: Rewrite Webform integration to use new mapping hooks that makes it unnecessary. The title_display options are pulled directly from Webform's component configuration now, rather than attempting to modify Form Builder's title_display options.