Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
The wrapping div element should be changed to a section.
https://skitch.com/jesse.beach/fkkg5/netbeans
The wrapping div element should be changed to a section.
https://skitch.com/jesse.beach/fkkg5/netbeans
Comments
Comment #1
chrispomeroy CreditAttribution: chrispomeroy commentedIs that all that needs to be done here?
Comment #2
chrispomeroy CreditAttribution: chrispomeroy commented.
Comment #3
chrispomeroy CreditAttribution: chrispomeroy commentedfixed the patch, it had some other changes in it
see also #1189834: Convert book-export-html.tpl.php to HTML5
Comment #4
Jeff Burnz CreditAttribution: Jeff Burnz commentedWhy would we use
section
for a node when in node template we usearticle
- this is an article of content, so usearticle
.Comment #5
chrispomeroy CreditAttribution: chrispomeroy commentedreplaced with article
Comment #6
xjmThanks for your work on this patch. Note that the Drupal 8.x patch will need to be rerolled, because the core directory structure for Drupal 8 has now changed. (For more information, see #22336: Move all core Drupal files under a /core folder to improve usability and upgrades). When the patch has been rerolled, please set the issue back to "Needs Review."
Tagging as novice for the task of rerolling the Drupal 8.x patch.
If you need help rerolling this patch, you can come to core office hours or ask in #drupal-gitsupport on IRC.
Comment #7
chrispomeroy CreditAttribution: chrispomeroy commentedmade the /core change
Comment #8
xjmThanks @chrispomeroy.
Comment #9
karschsp CreditAttribution: karschsp commentedLooks good to me. RTBC
Comment #10
JacineHmm, so I think we should wait on what happens with #1077602: Convert node.tpl.php to HTML5 and try to have some consistency between the two as far as the general markup structure and classes go, i.e. wrapping the content in a div, etc.
Comment #11
aspilicious CreditAttribution: aspilicious commentedThey put it in an article
Comment #12
JacineGreat, thank you @aspilicious :D
Comment #13
JacineAlso, tagging this so it's on the radar for this sprint.
Comment #14
catchThanks! Committed/pushed to 8.x.
Comment #15
JacineThanks! Removing the sprint tag.