Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chrispomeroy’s picture

Status: Active » Needs review
FileSize
3.6 KB

Is that all that needs to be done here?

chrispomeroy’s picture

.

chrispomeroy’s picture

fixed the patch, it had some other changes in it

see also #1189834: Convert book-export-html.tpl.php to HTML5

Jeff Burnz’s picture

Status: Needs review » Needs work

Why would we use section for a node when in node template we use article - this is an article of content, so use article.

chrispomeroy’s picture

Status: Needs work » Needs review
FileSize
613 bytes

replaced with article

xjm’s picture

Status: Needs review » Needs work
Issue tags: +Novice

Thanks for your work on this patch. Note that the Drupal 8.x patch will need to be rerolled, because the core directory structure for Drupal 8 has now changed. (For more information, see #22336: Move all core Drupal files under a /core folder to improve usability and upgrades). When the patch has been rerolled, please set the issue back to "Needs Review."

Tagging as novice for the task of rerolling the Drupal 8.x patch.

If you need help rerolling this patch, you can come to core office hours or ask in #drupal-gitsupport on IRC.

chrispomeroy’s picture

made the /core change

xjm’s picture

Status: Needs work » Needs review
Issue tags: -Novice

Thanks @chrispomeroy.

karschsp’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me. RTBC

Jacine’s picture

Status: Reviewed & tested by the community » Postponed

Hmm, so I think we should wait on what happens with #1077602: Convert node.tpl.php to HTML5 and try to have some consistency between the two as far as the general markup structure and classes go, i.e. wrapping the content in a div, etc.

aspilicious’s picture

Status: Postponed » Needs review
FileSize
800 bytes

They put it in an article

Jacine’s picture

Status: Needs review » Reviewed & tested by the community

Great, thank you @aspilicious :D

Jacine’s picture

Issue tags: +sprint

Also, tagging this so it's on the radar for this sprint.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Thanks! Committed/pushed to 8.x.

Jacine’s picture

Issue tags: -sprint

Thanks! Removing the sprint tag.

Automatically closed -- issue fixed for 2 weeks with no activity.