I wante'd to create a link in an userview to the users profilepage, like "show userprofile" with a simple field (not with custom text, link and user/[uid]) and created this patch.

CommentFileSizeAuthor
#9 user_path_field-1214430-9.patch575 bytesHydra
#7 user_path_field-1214430-7.patch1.87 KBHydra
#6 screen14.png60.7 KBdawehner
#5 user_path_field-1214430-5.patch1.88 KBHydra
#3 user_path_field-1214430-3.patch2.01 KBHydra
#1 user_path_field-1214430-1.patch0 bytesHydra
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Hydra’s picture

Hydra CreditAttribution: Hydra commented
FileSize
user_path_field-1214430-1.patch0 bytes

Here the patch

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

that's an empty patch...

Hydra’s picture

Hydra CreditAttribution: Hydra commented
FileSize
user_path_field-1214430-3.patch2.01 KB

sorry, something went wrong, here the patch

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Needs review

Update the status.

Hydra’s picture

Hydra CreditAttribution: Hydra commented
Status: Needs review » Active
FileSize
user_path_field-1214430-5.patch1.88 KB

Next try, I fixed the permissions for viewing the field

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Needs work
FileSize
screen14.png60.7 KB

Update status :)

Please install dreditor on your browser(firefox, chrome). Once you have this you will see a review link beside each patch,
see screenshot. There are empty spaces and some tabs.

Some more comments: 

+++ b/modules/user/views_handler_field_user_path.incundefined
@@ -0,0 +1,14 @@
+      if(user_access('access user profiles')) {

small code style problem if () instead of if() ... and you check for $data

Additional you should check that $data exists as on the previous patch.

That's the normal way of patch review process: firm but fair.

Hydra’s picture

Hydra CreditAttribution: Hydra commented
Status: Needs work » Needs review
FileSize
user_path_field-1214430-7.patch1.87 KB

Thank you for your advices dereine! Somehow like this?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Needs work

Technical this is the same field as "node: link", so this should be the same here

so $data['users']['view_user'] etc.
Additional the handler has to be renamed etc. I'm sorry for that.

Hydra’s picture

Hydra CreditAttribution: Hydra commented
Title: Field to userprofile in userview » make link to field usable
Status: Needs work » Needs review
FileSize
user_path_field-1214430-9.patch575 bytes

I found out, that the views_handler_field_user_link already was commited, just the registration of the field in user.view is missing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Fixed

Thanks!

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.