in mini panels module on panels_mini_block_info() i found some mistake, variable $mini (line number 77), is not used anywhere. May be it a misprint?

CommentFileSizeAuthor
#3 mini_panels_1212492.patch629 bytesLetharion
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
Title: Some mistake in code » Incorrect use of $mini in panels_mini_block_info()
Priority: Critical » Normal

1) Please use more descriptive titles than something that says there's a bug. Can you imagine how hard it would be to find an issue if every issue had such generic titles? All bugs are mistakes in code.

2) Critical? Really? There are guidelines on how to use the status values, you should read them.

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented

3) Quoting the incorrect code would've saved me the time of looking up the function to see the error, and since you were already looking at that code it would not have been any trouble at all on your part to do so.

Letharion’s picture

Letharion CreditAttribution: Letharion commented
Status: Active » Needs review
FileSize
mini_panels_1212492.patch629 bytes

Attaching patch, is this what's intended merlin?

Letharion’s picture

Letharion CreditAttribution: Letharion commented
Version: 7.x-3.0-alpha3 » 7.x-3.x-dev
merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
Status: Needs review » Reviewed & tested by the community

Looks like yes.

Letharion’s picture

Letharion CreditAttribution: Letharion commented
Status: Reviewed & tested by the community » Fixed

commit 7470be5787e9a5ea8661ebe5c793b22934b29356

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

SunRhythms’s picture

SunRhythms CreditAttribution: SunRhythms commented

This patch also worked here... *duplicate entry yet later for those that are still looking for resources*
http://drupal.org/node/1480366

  • Commit 7470be5 on 7.x-3.x, 7.x-3.x-i18n, 8.x-3.x by Letharion: 
    Issue #1212492 by letharion: Replace usage of non-existant variable with...