When I add a youtube uri, I cannot edit it's title. I think in beta4 title was editable but it is not in beta5.

#2 1210432-file-edit-filename.patch2.76 KBDave Reid
PASSED: [[SimpleTest]]: [MySQL] 17 pass(es). View
Members fund testing for the Drupal project. Drupal Association Learn more


tsvenson’s picture

Project: Media » File Entity (fieldable files)
Version: 7.x-1.0-beta5 » 7.x-2.x-dev

No new features will be added to the Media 1.x branch, moving to 2.x. Also, this is more likely something that should be added to the File Entity modules, so moving to it as well.

Title has its own column in the file_manage table and being able to edit it should be a standard feature available and easily done from the admin/content/file page.

Permissions will be needed so its possible to set who will be able to edit the title, own, all etc...

Dave Reid’s picture

Status: Active » Needs review
2.76 KB
PASSED: [[SimpleTest]]: [MySQL] 17 pass(es). View

Please review the following patch. We don't need additional permissions as what we have already is good enough and works exactly like other entity forms and titles.

Dave Reid’s picture

Assigned: Unassigned » Dave Reid
tsvenson’s picture

Status: Needs review » Reviewed & tested by the community

Patch applies cleanly on current dev and works.

Only thing that might be confusing is that users might think that changing the file name will also change the name of the physical file on disk. This is very easy to think since the physical file name now is used automatically.

Maybe we should rename this to "File title" and thus the column name to file_title as well. That would distinguish it from the physical file name.

I've also created #1397652: Add "Filename" field to upload/add media so the file name can be set when a new file is added to the site. It will save a lot of unnecessary steps when adding new files.

Dave Reid’s picture

Status: Reviewed & tested by the community » Fixed

We can't rename the column of a core table like that. :/

Committed #2 to Git! http://drupalcode.org/project/file_entity.git/commit/d90c3f8

Automatically closed -- issue fixed for 2 weeks with no activity.