When trying to create a shipping package always issues the following error(s)


•Notice: Undefined index: file in uc_shipping_make_shipment() (line 1059 of /home/content/21/7420121/html/sites/all/modules/ubercart/shipping/uc_shipping/uc_shipping.admin.inc).
•Notice: Undefined property: stdClass::$length_units in uc_ups_fulfill_order() (line 1097 of /home/content/21/7420121/html/sites/all/modules/ubercart/shipping/uc_ups/uc_ups.module).
•Notice: Undefined property: stdClass::$length in uc_ups_fulfill_order() (line 1101 of /home/content/21/7420121/html/sites/all/modules/ubercart/shipping/uc_ups/uc_ups.module).
•Notice: Undefined property: stdClass::$width in uc_ups_fulfill_order() (line 1105 of /home/content/21/7420121/html/sites/all/modules/ubercart/shipping/uc_ups/uc_ups.module).
•Notice: Undefined property: stdClass::$height in uc_ups_fulfill_order() (line 1109 of /home/content/21/7420121/html/sites/all/modules/ubercart/shipping/uc_ups/uc_ups.module).

It doesn't seem to be pulling the dimensions/weight from the product (which are set)?

Comments

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: Notice: Undefined index: file in uc_shipping_make_shipment() (line 1059 of » Undefined properties: $length, $width, $height in uc_ups_fulfill_order()

Fix committed for the first message. I don't personally use UPS so will find it difficult to test or fix that code.

tr’s picture

tr commented

I backported #1 to 6.x-2.x. I'll take a look at the other errors.

tr’s picture

tr commented
Priority: Major » Minor

Looks like these notices also pop up in uc_fedex under the same conditions (makes sense, as UPS and FedEX are the only modules that do label generation), and also show in 6.x-2.x when E_ALL is set.

Bumping priority down because the label generation works properly and this doesn't indicate any functional problem in the code. The only issue here is getting rid of those annoying PHP notices.

Note to self to backport any fixes in this issue to 6.x-2.x.

tr’s picture

tr commented
Status: Active » Fixed

This should now be fixed in the development version of uc_ups (and uc_fedex too). Feel free to re-open the issue if it's not.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.