API page: http://api.drupal.org/api/drupal/includes--form.inc/function/drupal_retr...
The function contain the following comment:
// $menu_get_item() is not available at installation time.
$menu_get_item() is really the menu_get_item() function, but the comment seems referring to the function whose name is contained in the variable $menu_get_item.
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | 1204784-includes-form-15.patch | 863 bytes | bdgreen |
| #11 | 1204784-includes-form-11.patch | 884 bytes | kevin morse |
| #9 | 1204784-includes-form.patch | 886 bytes | kevin morse |
| #1 | drupal_retrieve_form_doc.patch | 661 bytes | droplet |
Comments
Comment #1
droplet commentedComment #2
jhodgdonThe code right after that is checking for maintenance mode, not "installation time". So is the new comment still a bit misleading too?
Comment #3
avpadernoThe constant is used both in install.php, as
define('MAINTENANCE_MODE', 'install'), and in update.php, asdefine('MAINTENANCE_MODE', 'update').drupal_retrieve_form()is called bydrupal_build_form(), which is then called by install_run_task(); also update_selection_page() indirectly callsdrupal_retrieve_form(). The difference is that in the latter case, Drupal is fully bootstrapped, while in the first case, Drupal is not full bootstrapped.Finding out that is not that immediate; maybe the comment should be less "cryptic" about that point.
Comment #4
jhodgdonWell, the check is just defined('MAINT...') -- it isn't checking what the value is. So it seems like if we're fixing the comment, it should reflect what the code does?
Comment #5
Tor Arne Thune commentedChanging tags so webchick will get it displayed when searching for "needs backport to D7."
Comment #6
jhodgdon#1: drupal_retrieve_form_doc.patch queued for re-testing.
Comment #7
jhodgdonpatch actually is needs work, see comments above.
Comment #8
valthebaldSounds like an good first issue for someone with good English
Comment #9
kevin morse commentedFigured I'd give this a try... Not sure if I fully understand what's going on but we shall see.
Comment #10
valthebald#9: Looks good, but can you please remove extra spaces in the emd of comment lines?
Comment #11
kevin morse commentedTry this...
Comment #12
valthebaldLooks fine for me, let's see if that sounds clear enough.
Comment #13
jhodgdonThanks! This looks fine to me to. I'll get it committed soon, unless someone else beats me to it.
Comment #14
jhodgdonThanks again! Committed to 8.x. The patch does not apply to 7.x and needs a reroll.
Comment #15
bdgreen commentedPatch rerolled for 7.x
Comment #17
bdgreen commented#15: 1204784-includes-form-15.patch queued for re-testing.
Comment #18
valthebaldTestbot is happy, and change matches D8 version
Comment #19
bdgreen commentedThanks @valthebald ;)
Similar comments do not appear near function drupal_retrieve_form in D6 form.inc so haven't rolled a patch for D6. OK?
Comment #20
valthebaldRight.
Removind 'Needs backport...' tags (as far as we're already at 7.x)
Comment #21
jhodgdonAgreed, the patch is not needed for Drupal 6.x. I'll get the 7.x patch committed soon. Thanks!
Comment #22
jhodgdonThanks again! Committed to 7.x.