I'm getting a bunch of errors when I try to display a menu block on a forum page. I originally thought that this had to do with Advanced Forum, but I disabled that module and I'm still getting errors:

    Notice: Undefined index: hidden in menu_block_tree_output() (line 611 of /var/www/sites/oga2/featuretest/sites/all/modules/menu_block/menu_block.module).
    Notice: Undefined index: has_children in menu_block_tree_output() (line 629 of /var/www/sites/oga2/featuretest/sites/all/modules/menu_block/menu_block.module).
    Notice: Undefined index: href in menu_block_tree_output() (line 643 of /var/www/sites/oga2/featuretest/sites/all/modules/menu_block/menu_block.module).
    Notice: Undefined index: href in menu_block_tree_output() (line 643 of /var/www/sites/oga2/featuretest/sites/all/modules/menu_block/menu_block.module).
    Notice: Undefined index: mlid in menu_block_tree_output() (line 647 of /var/www/sites/oga2/featuretest/sites/all/modules/menu_block/menu_block.module).
    Notice: Undefined index: title in menu_block_tree_output() (line 658 of /var/www/sites/oga2/featuretest/sites/all/modules/menu_block/menu_block.module).
    Notice: Undefined index: href in menu_block_tree_output() (line 659 of /var/www/sites/oga2/featuretest/sites/all/modules/menu_block/menu_block.module).
    Notice: Undefined index: mlid in menu_block_tree_output() (line 665 of /var/www/sites/oga2/featuretest/sites/all/modules/menu_block/menu_block.module).

This appears to be happening because $data['below'] contains some links that have only an in_active_trail variable and nothing else.

CommentFileSizeAuthor
#12 menu_block_1204064_menu_tree_add_active_path.patch657 bytesmrharolda
#7 menu_block-1204064-2.patch668 bytespjcdawkins

Comments

bartk’s picture

bartk commented

Note that I'm not the only site this has happened to... A google search for the error has revealed a cached page with the same issue:

http://webcache.googleusercontent.com/search?q=cache:C3J3Gk4LoyQJ:www.nu...

bartk’s picture

bartk commented

I've got a fix for this that gets rid of the error message.

In menu_block.module, in the function menu_tree_add_active_path, change:

if ($tree_with_trail[$key]['link']['in_active_trail']) {

to

if ($tree_with_trail[$key]['link']['in_active_trail'] && array_key_exists($key, $subtree_pointer)) {

(around line 423)

It looks like the menu_tree_page_data is returning active trail items that aren't actually in the menu, but the function as it stands is assuming that they are.

isaacfreeman’s picture

isaacfreeman commented

I add this issue too, on many admin pages. BartK's fix has done the trick.

justmagicmaria’s picture

justmagicmaria commented
Title: Errors in Drupal 7 when using a menu block on a forum page. » Errors in Drupal 7 when using a menu block

Same. Note I changed the issue title since this isn't just on forums. BartK's fix worked for me too.

TimelessDomain’s picture

TimelessDomain commented
Status: Active » Reviewed & tested by the community

#2 works.

jras’s picture

jras commented

#2 worked for me as well.

pjcdawkins’s picture

pjcdawkins commented
Version: 7.x-2.2 » 7.x-2.x-dev
StatusFileSize
new menu_block-1204064-2.patch668 bytes

Here's a patch version of BartK's fix in #2.

acrollet’s picture

acrollet commented

Patch in #7 works for me, leaving as RTBC.

tjg’s picture

tjg commented

Any chance this patch will be included in menu_block soon?

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/menu_block.moduleundefined
@@ -467,7 +467,7 @@ function menu_tree_add_active_path(&$tree) {
+      if ($tree_with_trail[$key]['link']['in_active_trail'] && array_key_exists($key, $subtree_pointer)) {

The array_key_exists() portion should be replaced with isset($subtree_pointer[$key]), see http://php.net/array_key_exists#example-4540

Rory’s picture

Rory commented

@tim.plunkett - I couldn't find the example you were specifically linking to. But I thought this might be it: http://php.net/manual/en/function.array-key-exists.php#87491

It is important to realise that:

  isset($array ['index'])

Does not act the same as:

  array_key_exists('index', $array)

This is because if an array value is set to NULL

$array['index'] = NULL;

Then isset will return FALSE and array_key_exists will return TRUE.
mrharolda’s picture

mrharolda commented
StatusFileSize
new menu_block_1204064_menu_tree_add_active_path.patch657 bytes

Rerolled the patch with isset() like tim.plunkett suggested.

This patch fixes these notices:

Notice: Undefined index: has_children in menu_tree_depth_trim() (line 610 of /var/www/d7/sites/all/modules/contrib/menu_block/menu_block.module).
Notice: Undefined index: hidden in menu_block_tree_output() (line 646 of /var/www/d7/sites/all/modules/contrib/menu_block/menu_block.module).
Notice: Undefined index: has_children in menu_block_tree_output() (line 664 of /var/www/d7/sites/all/modules/contrib/menu_block/menu_block.module).
Notice: Undefined index: href in menu_block_tree_output() (line 678 of /var/www/d7/sites/all/modules/contrib/menu_block/menu_block.module).
Notice: Undefined index: href in menu_block_tree_output() (line 678 of /var/www/d7/sites/all/modules/contrib/menu_block/menu_block.module).
Notice: Undefined index: mlid in menu_block_tree_output() (line 682 of /var/www/d7/sites/all/modules/contrib/menu_block/menu_block.module).
Notice: Undefined index: title in menu_block_tree_output() (line 693 of /var/www/d7/sites/all/modules/contrib/menu_block/menu_block.module).
Notice: Undefined index: href in menu_block_tree_output() (line 694 of /var/www/d7/sites/all/modules/contrib/menu_block/menu_block.module).
Notice: Undefined index: mlid in menu_block_tree_output() (line 700 of /var/www/d7/sites/all/modules/contrib/menu_block/menu_block.module).

mrharolda’s picture

mrharolda commented
Status: Needs work » Needs review

Forgot to set status to 'needs review'...

pjcdawkins’s picture

pjcdawkins commented

#12 works for me

lstoetzel’s picture

lstoetzel commented

#12 works for me

gmclelland’s picture

gmclelland commented

Patch in #12 worked for me.

pjcdawkins’s picture

pjcdawkins commented
Status: Needs review » Reviewed & tested by the community

Still works for me! Marking RTBC.

Note that this issue is for the -2.x branch while there's also a -3.x. It looks like it's fairly trivial to produce a similar patch for 3.x, but let's keep this thread simple until the maintainer responds.

gmclelland’s picture

gmclelland commented

Sorry, I spoke to soon. The error I see is bit different and doesn't apply to this issue.

ayalon’s picture

ayalon commented

Tested and working

Please commit it.

Mirroar’s picture

Mirroar commented

Confirming that it works for me as well. Thanks for the patch!

jci’s picture

jci commented

Works for me - thanks! Please commit it.

Cauliflower’s picture

Cauliflower commented

Patch in #12 works as expected.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Title: Errors in Drupal 7 when using a menu block » Fix undefined index notices in menu_tree_add_active_path()
Status: Reviewed & tested by the community » Fixed

Fixed. http://drupalcode.org/project/menu_block.git/commitdiff/c7c644b

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.