Closed (fixed)
Project:
Commerce Core
Version:
7.x-1.x-dev
Component:
Commerce
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
29 Jun 2011 at 10:46 UTC
Updated:
4 Jan 2014 at 00:53 UTC
Jump to comment: Most recent
Comments
Comment #1
rszrama commentedWow! Any chance you'll post this to a separate project or something? I'm gearing up for an RC and won't be adding any new modules until 2.x, and something like this may be better in contrib anyways - would allow it to be continually improved regardless of the core development status.
Comment #2
das-peter commentedSure - I just didn't have the time yet to see how I've to proceed to get the own project ;)
The idea behind the new callback is exactly to be able to decouple this code.
Comment #3
rszrama commentedOh, I see. I didn't get that the patch was to commerce.module itself. Why could you not use the primary conversion callback... conversion itself should be the same math every time, right, based on conversion_rate values altered into the currency info array?
Comment #4
rszrama commentedWhoops, forgot about this one sitting in needs review. Committed.