The device= overrides do not seem to affect the panel rules.

When I use device=mobile, I get redirected to my mobile domain, the right theme gets selected, but I see the panel for the desktop device.

As far as I can tell, this is related to http://drupal.org/node/893378 but for the 2.x tree and with a different solution.

I believe mobile_tools_is_mobile_ctools_access_check() in mobile_tools/plugins/access/is_mobile needs to use mobile_tools_get_device() instead of mobile_tools_is_mobile_device() on line 62.

Making this change appears to work for me, but I am still testing it. I will try to generate a real patch, but this isn't totally straightforward for me on this particular site install.

Members fund testing for the Drupal project. Drupal Association Learn more

Comments

mpdonadio’s picture

FileSize
849 bytes

Just saw there has been no activity on this. I have had this live for a while now and have not run across any problems.

*** mobile_tools-6.x-2.3/plugins/access/is_mobile.inc	Mon Jan 19 17:26:36 1970
--- mobile_tools/plugins/access/is_mobile.inc	Mon Jan 19 17:26:36 1970
***************
*** 57,67 ****
  
  /**
   * Check for access.
   */
  function mobile_tools_is_mobile_ctools_access_check($conf, $contexts) {
!   $browser = mobile_tools_is_mobile_device();
    if ($conf['mobile_any'] && $browser['type'] == 'mobile') {
      return TRUE;
    }
  
    $access = in_array($browser['group'], $conf['mobile_list']);
--- 57,67 ----
  
  /**
   * Check for access.
   */
  function mobile_tools_is_mobile_ctools_access_check($conf, $contexts) {
!   $browser = mobile_tools_get_device();
    if ($conf['mobile_any'] && $browser['type'] == 'mobile') {
      return TRUE;
    }
  
    $access = in_array($browser['group'], $conf['mobile_list']);
mpdonadio’s picture

Version: 6.x-2.3 » 6.x-2.x-dev
Issue summary: View changes
Status: Active » Needs review
FileSize
545 bytes

This bug still exists in 6.x-2.x. Here is a re-roll via git.