Is it possible to switch from (height x width) to (width x height). This is the usual way to write dimentions (first width, then height). I know it will be a problem for people using this tag in their content and having specified the dimentions, but in the long run it will be better.

CommentFileSizeAuthor
#2 video_dimensions.patch4.28 KBprofix898
#1 image_dimensions.patch7.28 KBprofix898

Comments

profix898’s picture

profix898 commented
Status: Active » Needs review
StatusFileSize
new image_dimensions.patch7.28 KB

Actually I never thought of the "usual way" to specify dimension. In html the order of attributes doenst matter. But I agree width x height might be more common. The attached patch switches height/width and makes the help text for image.tags to use 50x40 instead of 50x50, so everyone can see what comes first. (I will also replace the wikipedia image with another one, which looks nicer when redimensioned.)

Maybe there should be a php script to fix the order of width/height arguments in node content using regexps.

profix898’s picture

profix898 commented
StatusFileSize
new video_dimensions.patch4.28 KB

Upps. Just realized you were talking about video.tags. Here is a patch for that one.

profix898’s picture

profix898 commented
Status: Needs review » Fixed

Committed to Drupal-5 branch together with some more updates. New release will follow in a few days ...

profix898’s picture

profix898 commented

The Drupal-5 development version looks quite stable now. I will tag a new release shortly.

A script to swap the image/video dimensions of exsting tags in nodes can be found at
http://www.profix898.de/ftp/public/Drupal/reptag_dimswap.php

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)