"Save and continue" button doesn't work when destination URL parameter is set

If you're talking about the save and continue button on the node edit form node/%/edit, that is controlled by Drupal. Ubercart has nothing to do with this. If you're not talking about that button, well maybe you could spare a few more keystrokes to fully describe your request.

"Save and continue" is actually added by uc_product_form_alter() to product node forms.

I think I understand what you mean, but not sure about your hook_exit implementation - if you can provide a patch that would help get this feature included.

Patch looks good, and incredibly well commented - I just need time to test it.

@shp: If you click on "View details" in #10, you will see that the testbot reports that your patch is in an invalid format, and tells you to "Ensure the patch only contains unix-style line endings."

I also think that using hook_exit() should be avoided at all costs, because it has impact on caching. Any patch which creates a new implementation of hook_exit(), like this one does, is going to need testing under a variety of circumstances to ensure that a little fix like this doesn't cause a major unintended behavior difference.

Marking as "minor" because this only has a very small number of use cases that I can see.

Can we just get away with a simpler implementation of unsetting $_REQUEST['destination'] in the submit handler, and not using hook_exit()? This means that ?destination URLs will be lost when using Save & continue, but that's an even more minor problem than the original issue here.

If we do go with this method:

+  // Determine if the Destination is an absolute URL or not (see drupal_goto()).
+  $colonpos = strpos($destination, ':');
+  $absolute = ($colonpos !== FALSE && !preg_match('![/?#]!', substr($destination, 0, $colonpos)));
+
+  // If it is absolute, we will not take the Destination back to the URL -
+  // thus, we don't need to backup it. Otherwise we backup it.
+  if (!$absolute) {
+    $GLOBALS['destination_backup'] = $destination;
+  }

Why bother duplicating the work that drupal_goto() does? Just back up the destination as provided, and let drupal_goto() perform sanity checks on it when it will actually be used.

Also, when is $_REQUEST['edit']['destination'] actually used instead of just $_REQUEST['destination']? I can see core deals with this case, but do we need to handle it here as well?

I just needed to fix this, attached is a patch for D7, haven't really reviewed the other patches but as there were complains and they fail tests, mine is really a simple one.

Also something very similar can be done for D6, but slightly different. I stumbled upon with this useful post that allowed me to work out this patch very nicely: https://drupal.org/comment/4792980#comment-4792980

EDIT: I also change it to a minor "Bug" because of what you'd expect from the "Save and continue" button.

EDIT: Cleared because I really wanted to update the Issue summary. Will do that now.

Bumping this easy fix, still applies to 3.8.