I tried JQuery update 2.0 alpha 1 and also -dev version (2011-Apr-20) Both of them break "Edit Order" page. In the list of product ordered where you should be able to delete or change quantity is disappear and shows below sentence.

Loading product information... (If nothing happens, make sure you have Javascript enabled.)

When I click "add product" or "blank line", those list came up and it works fine. I can add, edit, delete without any problem. Calculation works fine.

Also, in the shipping cost that I can click to see the list of shipping. It's no longer work. Once click, the page is saved without showing me any list of shipping method.

I also tested it with Ubercart 2.0-dev lasted one. (Jun 19) Same problem. disable JQuery update fixed the problem.

Comments

abx’s picture

abx CreditAttribution: abx commented
Title: Ubercart Edit Order break when update JQuery » "JQuery Update" breaks Ubercart "Edit Order" page
TR’s picture

TR CreditAttribution: TR commented
Version: 6.x-2.4 » 6.x-2.x-dev
Category: bug » feature

Ubercart JavaScript is intended to work properly with the version of jQuery that is distributed with Drupal. If you would like to support a newer version of jQuery, we will happily accept patches for that so long as they don't cause the JavaScript to fail under the Drupal default version of jQuery.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented

Marked #1100822: Submit Changes button set to disabled="disabled" by default as duplicate

j0rd’s picture

j0rd CreditAttribution: j0rd commented

subscribing. Colorbox requires jquery_update . We might want to remove this from suggested modules on Ubercart 6.

I personally haven't encountered any other issues with jquery_update aside from this one though.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented
Status: Active » Postponed (maintainer needs more info)

Cannot reproduce this. New install of Ubercart 6.x-2.x-dev, jQuery Update 6.x-2.0-alpha1, Garland theme. Order edit page all works as expected, including product listing and shipping quote button.

j0rd’s picture

j0rd CreditAttribution: j0rd commented

Try zen theme.

Perhaps the css class/id's are different. Most people won't be using garland.

Update: Also I believe this is not working because of Payment gateways, which is what is causing the ajax to fail. I currently have Paypal WPS & Paypal Express Checkout & Authorize.net enabled.

j0rd’s picture

j0rd CreditAttribution: j0rd commented

I just noticed this in Firebug.

POST http://domain.tld/admin/store/orders/452/payment_details/credit (302 Found)

The 302 is redirecting to https://domain.tld/admin/store/orders/452/payment_details/credit (HTTPS)

There's the error.

I have this in securepages module config

Make secure only the listed pages:
cart/*
pay
paysuccess
*/store/*/credit

These are not normally paths I normally put in this setting and my client is not wise enough to add "*/store/*/credit" to the settings. This would leave me to believe either Authorize.net suggested it, or they found documentation some where else on the net.

I'm still having problems with "Add Line" in Line Items & "Apply to Order" in Shipping being disabled.

Looking into that.

Update: "Add Line" & "Apply to Order" issues were a problem specific to me. That's resolved now too and everything is working as expected.

I'll contact my client and ask them where they found those securepages settings and come back with an answer if they have one.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented

Does this only happen in Firefox? Seems related to a browser bug: http://bugs.jquery.com/ticket/9155

abx’s picture

abx CreditAttribution: abx commented

Just tested with Garland, got the same problem. Also, tested with Safari 5.1 / IE 8. Same thing. But Longwave already tested Garland without any problem. Strange!! I don't use Paypal at all. Secure page used to be there but I took it out a week ago. The only different thing here is that, I tested it with Ubercart 2.4, not dev version. So, I will try to update Ubercart to 2.6 and test it again.

abx’s picture

abx CreditAttribution: abx commented

Just updated Ubercart to 2.6 Still got the same problem. I think I may stick with Original JQuery for now.

j0rd’s picture

j0rd CreditAttribution: j0rd commented

An update after talking with my client. They were the ones sticking that value into secure pages trying to make sure Credit Cards were sent secure over the wire. I didn't think they were technically savvy enough to get at that actual ajax endpoint.

Either way, my problem is resolved, but it appears this is still happening for others.

My problem happened in Firefox & Chrome, but I believe my problem is different than others were having.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented

@abx: What other JavaScript do you have enabled on that page? Do you have JavaScript aggregation enabled? Can you test in Firefox with Firebug installed and see if any JavaScript errors are reported, or if any redirects are occuring (as in #7)?

abx’s picture

abx CreditAttribution: abx commented

I have JavaScript Aggregator 1.5 enabled. The only report I found in Firebug / Firefox is 

uncaught exception: Syntax error, unrecognized expression: [@name*=delivery_country]

Anyway, I just tried to disable each module that could be the problem until I found it. My problem is because I used "UC Discount Framework 6.x-1.x-dev". Disable it make the page running correctly now. Too bad that I have to stick with Original JQuery since I need UC Discount Framework :(

Thanks longwave.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented
Category: feature » support
Status: Postponed (maintainer needs more info) » Fixed

@abx: #628040: JavaScript error has a patch you could try out.

abx’s picture

abx CreditAttribution: abx commented

Tried to patch it but I got an error : (Tried both -p0 / -p1)

# patch -p0 < uc-discount-js-errors.patch 
(Stripping trailing CRs from patch.)
patching file uc_discount.js
Hunk #1 FAILED at 17.
1 out of 1 hunk FAILED -- saving rejects to file uc_discount.js.rej

I think it's ok. The reason I tried JQuery update was to play with Colorbox but I think I'll wait for Ubercart 3 to come out and try that later :)

Thanks,

TR’s picture

TR CreditAttribution: TR commented

If it doesn't work then just do it by hand. The patch just removes the "@" in places, since jQuery syntax has changed in more recent versions.

Regardless, any further discussion of that patch or UC Discount Framework should take place in that other issue queue.

abx’s picture

abx CreditAttribution: abx commented

Ok, thanks TR.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

rickupdegrove’s picture

rickupdegrove CreditAttribution: rickupdegrove commented

The modules/uc_discount/uc_discount.js is also a problem.

I manually edited this and removed all the @ signs in the file.

I can now check out...

TR’s picture

TR CreditAttribution: TR commented

@rickupdegrove: uc_discount is a separate module, not part of Ubercart, so I suggest you report that in the uc_discount issue queue.