when switching on d_t it has nuked the ds template and used the node template instead. Given the nature of the beast, that's most unfortunate hence the major.

CommentFileSizeAuthor
#4 devel_themer-alter-registry-late.patch2.06 KBeffulgentsia
#3 1193586.patch477 bytesswentel
#2 1193586.patch527 bytesswentel

Comments

swentel’s picture

swentel commented
Priority: Major » Normal

Meh, looks like the weight of ds is the problem - or the weight of devel_themer. Fun racing conditions in theme_registry_alter. If I change the weight of devel_themer to say 10, than all is ok again. So there are options:

- either file this agains devel_themer and a small patch againsts devel_themer.install to set the weight
- or maybe devel_themer_implements_alter() to inject their registry_alter as latest function
- check in ds_module_implements_alter to make sure devel_themer is last - which imo is the least interesting option.

tbh, I think option 1 is better, because there might be other modules/apps out there who want todo things on preprocessing.

swentel’s picture

swentel commented
Title: devel_themer is incompatible with ds » devel_themer_theme_registry_alter() comes to early sometimes
Project: Display Suite » Theme developer
Status: Active » Needs review
StatusFileSize
new 1193586.patch527 bytes

Modules with a lower weight implementing preprocess_hooks or injecting them also into the registry with hook_theme_registry_alter() are not found in devel_themer_theme_registry_alter(). Patch attached lowers the weight and fixes it all.

swentel’s picture

swentel commented
StatusFileSize
new 1193586.patch477 bytes

Better patch using hook_module_implements_alter()

effulgentsia’s picture

effulgentsia commented
Status: Needs review » Fixed
StatusFileSize
new devel_themer-alter-registry-late.patch2.06 KB

Thanks. Tweaked #3 a bit, and committed this to master branch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.