Image URL error - fails to display any banner

When you goto the form what is the prefix for the imgurl path?

I'm experiencing a similar problem - have a multisite setup

the url the banner is set up for is node/1
the banner url is sites/fitness.io/files/banners/parkour.jpg

the node it should appear at is http://www.fitness.io/node/1

thx,
Ken

I've had the same issues. I've actually had to hack the template file (in the sites/all/modules/dynamic_banner/templates/ directory) and hard-code in the url temporarily to find it. The issue is that you set the save path in the configuration, but it does not print the same path to the browser. The "public://" text varible is misleading and if you begin to search around it is peculiar the paths that you get.

I think this would be a relatively easy fix.... at the moment it does disable the module completely.

I think the problem is the way this module handle file paths.

      $file = file_load($imgfid);
      // have to translate the public string in the uri back into something browsers understand
      $file_path = str_replace('public://', variable_get('file_public_path', '') . '/', $file->uri);
      return $file_path;

We should just use file_create_url() instead of dealing with public://.

Or even better, use theme_image() in the template instead.

Hi, I have the same problem, again it doesn't find the image in a multisite setup.
Does anyone have a patch for that?

Sorry, I didn't recognize. This Issue is for Version 7.x-1.0

Hi, here again under the correct version number.
Same issue, the banner doesn't show the correct immage urls in a multisite configuration.

Also I get following error where I don't know if that has to do with it.
Notice: Trying to get property of non-object in dynamic_banner_image_delete() (line 813 of /drupal/sites/mysubsite/modules/dynamic_banner/includes/callbacks.inc).

I have another project consuming all my time but I have queued up this task as I see it is picking up more people along the way. I will really try to fix this soon.

So if I got this correctly firstly there is a php legacy compatibility problem between 5.3 and 5.2 which I know the module has had that before using the strange string manip that it does. So I will try to find the offending code.

Then there is a multi site problem that spans both 6 and 7 versions. I was also seeing the non object error in 7 so they may have updated and I just haven't noticed.

There is a settings suggestion for using a theme or file_create_uri which I need to review thanks for that.

But that just about covers it. Right?

Hi, sorry for this errors ;-)
Should I then open a new issue with the same problem for 7.x?

And thanks for the 'non-object' response. Mixed there two different issues into one.

Works perfectly with that new method, awesome! Hopefully no more multi site problems? Please test this theory out for yourselves tomorrow when the dev version gets updated with the commit or just grab the repo from the public git. Note the template file had to change to allow for this difference in url pattern as a / was used to call internal files, and well that is not needed anymore.

Sure Ill work on the back port for you bud. I realize where the problem is now so hopefully it wont take me long (cross fingers). Ill let you know.

Here's a short term solution (tested on 7.x-1.0) until an offical patch is released by the original creator:

//callbacks.inc
//around line 765
    else {
      $file = file_load($imgfid);
      // have to translate the public string in the uri back into something browsers understand
      //$file_path = str_replace('public://', variable_get('file_public_path', '') . '/', $file->uri);	  
	  global $base_url;
	  $file_path = str_replace('public://', $base_url . '/' . conf_path() . '/files' . '/', $file->uri);
      return $file_path;
    }

also in banner_output_template.tpl.php:
do a global search for '/$url' and replace with '$url' (remove the slash)