I have two node types on my site that accept signups. One for "purchasable" signups (i.e. uc_signup), and one for non-purchasable. I just updated to dev yesterday to deal with the duplicated signup fieldset/uc_signup button, which worked great, but then the signup fieldset disappeared on all of our non-product nodes that have signups enabled.

Pretty simple fix, just check in the uc_signup_signup_suppress function to see if the node being tested is actually a product. If it's not, uc_signup should leave it alone, by definition.

Patch attached.

CommentFileSizeAuthor
uc_signup_node_test.patch625 bytesstockliasteroid

Comments

ezra-g’s picture

ezra-g commented
Status: Needs review » Fixed

Great point, thanks.

There's one other place where we need to need to change the logic, so I made this change and also clarified the text for the setting that's now called, "'Skip checkout for free signup-enabled *products*" rather than *events*.

Committed. Thanks!

ezra-g’s picture

ezra-g commented

http://drupalcode.org/project/uc_signup.git/commitdiff/3952e91?hp=7d7803...

stockliasteroid’s picture

stockliasteroid commented

Great, thanks! One less patch to maintain on my site :).

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.