Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
the 'add line' item is always disabled on 'admin/store/orders/xxx/edit'
I can select 2 items in the menu in the same pane ('shipping' and 'empty line') but the 'add line' buttons stays disabled?
Any clues?
Comment | File | Size | Author |
---|---|---|---|
#5 | 1186894-addlineitems.patch | 2.96 KB | bwynants |
#4 | addlineitem-1186894.patch | 3.25 KB | bwynants |
Comments
Comment #1
bwynants CreditAttribution: bwynants commentedIf i go to admin/store/orders/xxx/add_line_item/shipping via an url it works just fine... so my only problem is the disabled button...
Comment #2
bwynants CreditAttribution: bwynants commentedone part of the problem is in uc_order_pane_line_items
should be
and then the disabled should become false where the button is created
Comment #3
bwynants CreditAttribution: bwynants commentedokay, button never got enabled because 'release_held_buttons' was removed from uc_order.js
Comment #4
bwynants CreditAttribution: bwynants commentedpatch included
Comment #5
bwynants CreditAttribution: bwynants commentedcorrect patch
Comment #6
longwaveI wonder if we even need this "order holds" mechanism at all, I am not sure why it is needed.
Comment #7
bwynants CreditAttribution: bwynants commentedtoday it is still is used in payment module #1187018: javascript function missing. So if it is not needed we should remove it there. and also the 'add line' button was depending on it....
Comment #8
longwaveCommitted the uc_order.order_pane.inc part of this patch, as the order hold mechanism is now removed.
Comment #9
bwynants CreditAttribution: bwynants commentedsomehow i miss one change in uc_order.js i'm not sure if i ever created a patch for it...
needed to be able to delete the lines you added
-/+ are reverted because it's a div with my branch
Comment #10
OldAccount CreditAttribution: OldAccount commentedConfirming the #5 patch works. Applied the uc_order.order_pane.inc part only and now the "Add line" button is re-enabled on the Edit Order screen.
Thanks!