Title says it all.

CommentFileSizeAuthor
#2 1186042-pi-content-extra-fields.patch1.06 KBDave Reid
#1 1186042-pi-content-extra-fields.patch944 bytesDave Reid
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Active » Needs review
FileSize
1186042-pi-content-extra-fields.patch944 bytes
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
FileSize
1186042-pi-content-extra-fields.patch1.06 KB
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Needs review » Reviewed & tested by the community

Great!

The patch in #1 had the help text at the top of the issue kind of showing up in random places, but the one in #2 correctly exposes all of the fields. I was able to re-order the fields and get the *@#ing revision fieldset down where it belongs. YAY!

Code looks good and conforms to coding standards. I don't believe this needs automated tests, because it's just hooking into a CCK API, which should have its own tests. RTBC!

dww’s picture

dww
we/he/they
CreditAttribution: dww commented
Status: Reviewed & tested by the community » Fixed

Thanks! Tested and working properly. Committed to 'master':

http://drupal.org/commitlog/commit/1894/06935546b7aac96b2b916fa335dfd65e...

However, I noticed that core CCK using trailing periods for these name fields, so I added those for consistency:

http://drupal.org/commitlog/commit/1894/d18542ef3d4d012d591d89c08c78dfb2...

Another step closer to #1036132: Provide a mechanism for issue summaries ... ;)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented

Oops. Good catch.

Thanks SO much for the commit, dww! :D YAY! :D

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.