Context error on update from 6.x-2.2 to 6.x-2.3 [#1185974]

Hi,

I upgraded 6.x-2.2 to 6.x-2.3 and contexts for mobile device in context condition stopped working. Then, I downgraded to 6.x-2.2 again and it started working again.

Am I missing something on upgrade process? Or, is this a bug? I can't provide any suggestions yet since I'm new to Mobile Tools and Context API.

Thanks :)

Comment	File	Size	Author
#1	context_fix-1185974-1.patch	588 bytes	justin2pin

Comments

Comment #1

justin2pin commented 12 June 2011 at 17:31

Status:

Active

» Needs review

Status	File	Size
new	context_fix-1185974-1.patch	588 bytes

Not sure if this is the same issue, but when I initially installed mobile_tools -- before upgrading context -- I white screened because the earlier version of context did not use the function context_get_plugin(). The attached patch uses function_exists("context_get_plugin") rather than module_exists("context"), which will at least prevent a fatal PHP error.

To get context integration, you'll still need to upgrade to the latest stable context release.

Comment #2

gantenx commented 17 June 2011 at 03:40

It's different issue. Well, it looks like I didn't clearly say what the problem was. :-P

I was using Context 6.x-3.0 and Mobile Tools 6.x-2.2 to detect client's device. My system detected devices correctly until I updated Mobile Tools to 6.x-2.3 version. There was no error message appeared. It just failed in device detection.

Comment #3

danielphenry commented 14 September 2011 at 15:23

just hit this one as well. Any ideas what is causing this?

Comment #4

danielphenry commented 14 September 2011 at 15:44

Got it. Real simple fix so I didn't bother to create a patch

in mobile_tools.module
function mobile_tools_init
line 217

   if(module_exists('context')){
      $plugin = context_get_plugin('condition', 'mobile');
      if(!$plugin){
        $device = mobile_tools_get_device();
        $plugin->execute($device['type']);
        $plugin->execute($device['group']);
      }
   }

Should be:

   if(module_exists('context')){
      $plugin = context_get_plugin('condition', 'mobile');
***      if($plugin){ ***
        $device = mobile_tools_get_device();
        $plugin->execute($device['type']);
        $plugin->execute($device['group']);
      }
   }

Just a problem of using the wrong polarity in the if statement.