During development I've been saw that Drupal.behaviors.rubik have such jquery selectors that does greatly slowing down javascript execution of the page. I've been test it on IE 8 (in example) - browser suggest to stop slow script, and the slow script was rubik.js.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | Syntax-Rubik-js-1184722-7.patch | 1.14 KB | kyletaylored |
| #2 | rubik-1184722-2.patch | 2.12 KB | jslayer |
| #1 | rubik-1184722-1.patch | 2.12 KB | jslayer |
Comments
Comment #1
jslayer commentedHere is the patch which seems are going to fix this problem
Comment #2
jslayer commentedFirst patch has an error
Comment #3
gregglesBetter status. I clicked around a bit and didn't see any new problems, but I didn't do a full test and my js-foo isn't good enough to be able to critique the patch much.
Comment #4
charlie-s commentedI just noticed this as well. I have some custom code that runs an $.ajax() on link click and returns a true or false. Switching from Garland to Rubik caused the response time to go several multiples of the ~100ms it was taking in Garland.
I applied the patch in #2 and noticed positive improvement.
Comment #5
haydeniv commentedCommitted: d8e5f5a
Thanks!
Is this a problem in 7.x?
Comment #6
haydeniv commentedDowngrading until we know this is an actual problem on 7.x.
Comment #7
kyletaylored commentedI have a simple syntax patch, but other than that everything seems fine in 7.x I would propose to close this issue.
Comment #8
haydeniv commentedLooks straight forward enough.
Committed: 563fa5f
Thanks!