During development I've been saw that Drupal.behaviors.rubik have such jquery selectors that does greatly slowing down javascript execution of the page. I've been test it on IE 8 (in example) - browser suggest to stop slow script, and the slow script was rubik.js.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jslayer’s picture

FileSize
2.12 KB

Here is the patch which seems are going to fix this problem

jslayer’s picture

FileSize
2.12 KB

First patch has an error

greggles’s picture

Status: Active » Needs review

Better status. I clicked around a bit and didn't see any new problems, but I didn't do a full test and my js-foo isn't good enough to be able to critique the patch much.

charlie-s’s picture

I just noticed this as well. I have some custom code that runs an $.ajax() on link click and returns a true or false. Switching from Garland to Rubik caused the response time to go several multiples of the ~100ms it was taking in Garland.

I applied the patch in #2 and noticed positive improvement.

haydeniv’s picture

Version: 6.x-3.0-beta2 » 7.x-4.x-dev
Status: Needs review » Active

Committed: d8e5f5a

Thanks!

Is this a problem in 7.x?

haydeniv’s picture

Priority: Critical » Normal
Issue summary: View changes

Downgrading until we know this is an actual problem on 7.x.

kyletaylored’s picture

I have a simple syntax patch, but other than that everything seems fine in 7.x I would propose to close this issue.

haydeniv’s picture

Status: Active » Fixed

Looks straight forward enough.

Committed: 563fa5f

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.