I'm not familiar with D7's history, but terms_from_node seems to be referencing an old node field, taxonomy, which I don't think is valid anymore. I've updated the plugin to use field_info_instances() to find taxonomy term fields which seems to be the common practice.

Patch attached.

CommentFileSizeAuthor
terms_from_node_taxonomy.patch1.34 KBinolen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

inolen’s picture

inolen CreditAttribution: inolen commented

I'm curious to know as I'm new to the Drupal community, is there a better way to tag issues/suggested patches to make sure they are noticed/reviewed by devs?

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented

You did this correctly. Your patch was noticed, but I'm very busy and right nwo I'm trying to get a Views 7.x-rc out, so CTools patches are not getting looked at until I get back to it.

Sorry, this is the curse of having 3 major projects.

inolen’s picture

inolen CreditAttribution: inolen commented

No worries, I wasn't at all trying to sound pushy, I just wanted to make sure I was being effective :)

Thanks for all the hard work.

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
Status: Active » Fixed

Finally got back around to this. It turns out one minor problem is that this was not marked 'needs review', and I didn't notice that when I wrote #2. I've had a couple of patch review sessions since I posted that, but always missed this because it's just reported as a bug that needs fixing.

Anyway, your fix looks reasonable, so I committed it.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.