This module looks very useful, especially for a wiki I'm currently building.
However, the D7 version isn't really finished, and there haven't been any commits since the Great Git Migration. Maintenance and development status also weren't set on the project page. Will this project continue to be maintained, and see a finished D7 release any time soon? Or are there other modules one can use?

Comments

snupy’s picture

snupy commented

Subscribe

hansfn’s picture

hansfn commented

I would say it's unmaintained. Very little activity, and no reply when I tried to contact the two top / most recently active maintainers this spring - offering my help.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Title: Is this project still maintained? » Offering to maintain Diff

Found this page detailling how to take over abandoned projects.

While I also don't really have time to work on this project, I'd at least review and commit patches of others. Currently, the D7 version is hardly usable, but there are (as far as I can tell) perfectly working patches for all issues, so a committer is all that would be needed.

If someone with the time (and abilities) to really work on the module would be willing to take over, this would of course be even better, so please reply here if this is the case for you.

I'm also contacting yhahn and realityloop to see whether they maybe reply that way, and what they'd think about this.

jduguid’s picture

jduguid commented

subscribe

Hakaku’s picture

Hakaku commented

I can offer my help to roll in a number of existing patches and provide support, but I can't say I'd have the time to make any major revamps to the module. Any luck contacting yhahn & all?

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented

Any luck contacting yhahn & all?

Nope, none. :-/
The 14 days will be over on Wednesday, I'll then create the Webmasters issue … Maybe we can both become maintainers? Or just you, if you would also provide support?
Do you have any experience managing a Drupal project? Or with Drupal development in general?

realityloop’s picture

realityloop commented

In the short time I am happy to apply any patches that are required, I've been very busy lately due to taking my company full time.

I currently don't have sufficient permissions to add other maintainers so would suggest that would be the best starting point.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented

Ah, that would be great! Committing the existing patches is really all we want at the moment.
However, if you'd like it better to pass on maintainership, I guess we could still post that to the Webmasters issue queue, as none of the other maintainers (including those with sufficient permissions) has reacted. But, as said, if you could just find the time to commit patches marked as RTBC about once a week or so, that probably be good enough, and surely a vast improvement.

The following issues (which have working patches) should be taken care of and then a new beta released, in my opinion:
- #994204: All revisions display Anonymous as the revision author
- #1014062: Improper use of t()
- #1202560: Improper use of drupal_add_css() (OK, admittedly I just added that one myself, and somehow everything seems to work without it anyways.)
Also, please create a 7.x-2.x-dev release, as asked for in #1115280: Dev release for 7.x-2.x.

Hakaku’s picture

Hakaku commented

Maybe we can both become maintainers? Or just you, if you would also provide support?
Do you have any experience managing a Drupal project? Or with Drupal development in general?

I'd say add both, unless realityloop patches everything, then I won't have much to do. I can't say I have much experience maintaining a Drupal project specifically, so you might be a better choice in that regard, but I have managed projects with revisioning systems for other things. I do, however, work quite a bit with Drupal and this particular module is fairly important to my needs.

But for a next release, I think we need to do a little more than fix just those three issues. I'd suggest looking into all of these:
- #1182616: sometimes the complete diff on both sides turn red, only hint a notice in the log
- #1029768: Error on diff : Undefined index: und in node_diff()
- #1122206: "Show diffs inline" produces Notice
- #994204: All revisions display Anonymous as the revision author
- #1115638: Inline diff showing wrong revision
- #934608: Misspelling causes deleted text not to be highlighted
- #1014062: Improper use of t()

I think there were a few others I had tested on 7.x now marked as fixed. Some of these issues are marked as 6.x, but apply to 7.x as well. Haven't tested #1202560 yet, but I presume it's good.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented

But for a next release, I think we need to do a little more than fix just those three issues. I'd suggest looking into all of these:

The others don't seem to have working patches, yet. I also think they are rather special cases, whereas the others are problems all Diff users will have.
So while they certainly should be fixed, I think it would be better to get a more or less working Beta right away, then wait for all the other issues (when realityloop even said he won't have time to work on them himself.
Also, #934608: Misspelling causes deleted text not to be highlighted only affects 6.x, so would be irrelevant for a new 7.x Beta release. For 6.x, I don't really have an idea what is still missing for a new release. However, that version should already work quite well in most cases, as far as I'm aware? So 7.x would be more urgent right now.

Hakaku’s picture

Hakaku commented

The bug still applies to 7.x-2.0-beta2, see line #308 of diff.theme.inc:
$output .= theme('diff_inline_chunk', array('text' => t('Deleted'), 'type' => 'relete'));

Same thing with the inline diff issue: $old_vid should be changed to $node->vid, otherwise the wrong revision is displayed. Line #140 of diff.module:
$build = array('#markup' => diff_inline_show($node, $old_vid));

I'm also not sure as to what you qualify as an issue that doesn't affect all users. Syntax errors and failure to check if variables are set before using them are by default issues that apply to everyone, since they're fundamental PHP mistakes. And unless you're suppressing errors, you will stumble upon them here and then.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented

We don't have to argue over this here. realityloop should just commit all patches that have an RTBC status and then create a new Beta release, as the current one doesn't even work for the most basic use cases. If there are then still some serious problems, no-one is stopping him from doing another Beta two weeks later.

And if you find the other issues important too, just create and review patches for them, and they will now hopefully be committed.

realityloop’s picture

realityloop commented
Status: Active » Closed (fixed)

I think it's safe to close this now.