Can't imagine why there would even be code in SN module to touch the term tables; but...

whenever i modify a "newsletter" settings at url like: admin/content/simplenews/types/edit/155

and hit submit... SN modifies the structure of my taxonomy..

in case it matters, structure is like

Travel
- Air
- Marine

if i edit newsletter for Marine, and submit, i end up with this:

Marine
Travel
- Air

and i do get a msg saying "Updating term Marine"

CommentFileSizeAuthor
#2 keep_heirarchy.patch778 bytesliquidcms

Comments

liquidcms’s picture

Status: Needs review » Active

ahh... now i see.. in the submit function for that form there is code for:

// Create or update taxonomy term for this newsletter.
// When creating a term $form_state['values']['tid'] is NULL.

i think you are trying to let that form set the terms Description, weight, etc.. but not doing it correctly so it messes up tax structure.

i'll see about patch.. or maybe just comment all that out.. since i dont need it.

liquidcms’s picture

Status: Active » Needs review
StatusFileSize
new778 bytes

and here is the patch to fix.

liquidcms’s picture

Title: when newsletter configuration save; taxonomy structure is modified » saving newsletter configuration breaks taxonomy structure
Status: Active » Needs review
simon georges’s picture

Version: 6.x-2.x-dev » 7.x-1.x-dev
Priority: Critical » Normal
Status: Needs review » Patch (to be ported)

I don't think newsletters have been thought to have a hierarchy, that's probably the reason, but good catch anyway, and thanks for the patch !

Commited, to be ported to 7.x-1.x.

simon georges’s picture

Version: 7.x-1.x-dev » 6.x-2.x-dev
Status: Patch (to be ported) » Fixed

I just tested, there's no need for the patch in 7.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.