Pager, tablesort links in a form point to system/ajax when reloaded via AJAX

In order to call this a bug report, clear steps to reproduce the bug are required.

That sounds sufficient for me. Next step would be to convert those steps into a test, to confirm the bug exists, and prevent it from being re-introduced after it has been fixed.

subscribe

Here is a patch to add tests for pager and tablesort links in ajax enabled forms. As demonstrated by these tests, if theme('pager', ...) and theme('table', ...) are called from the form builder functions, the produced links correctly point to the page URL (and not system/ajax). But if the pager or table are returned as render arrays (ie. array('#theme' => 'pager', ...) and array('#theme' => 'table', ...)), the links point to system/ajax.

subcribe

I'm experiencing this problem too in drupal 7.12. I'm trying to build a tableselect using theme() function and #markup, as in the patch above, and it does seem to solve the system/ajax problem when an ajax action is triggered, but I'm not being able to change the table in the ajax function afterwards nor to use the pager. Are there any resources on how to build tableselects using theme function to solve the system/ajax problem?

@Kvitz: The patch in #7 only add tests to demonstrate the issue, it does not solve it.

The workaround, if I remember correctly, is the render the pager in the form builder. So instead of something modern like

$form['foo']['pager'] = array(
  '#theme' => 'pager'
);

You do it old-style and call theme('pager') pager to generate the content of a markup element

$form['foo']['pager'] = array(
  '#markup' => theme('pager')
);

Edit: Oups, I misread your post. Sorry, AFAIK, there is no documentation or resource to solve this. I made some ugly JavaScript hacks to work around this and rewrite the links but nothing worth sharing (as it lacks documentation and is really tied to a specific form).

subscribe

I've managed to solve it next way:
$_GET['q'] param is used by pager to get current page path. So I set page path I need.

$_GET['q'] = YOUR_BASE_PAGE_PATH; 
$pager = theme('pager', $variables);

I hope, it helps someone else.

Hola recien tengo un problema con el siguiente error:

An error occurred while attempting to process /es/system/ajax: this._each is not a function

Alguien ha resuelto esto?

Thanks Leonid.adcillc. This has indeed improved my problem. It now points to the right place. My only problem now is dealing with multiple paged tables in the same drupal form.

I'm seeing this issue in 7.20. In my case I worked around it by saving the value from GET at the first view of my form:

$form['q'] = array('#type' => 'value', '#value' => isset($form_state['values']['q']) ? $form_state['values']['q'] : $_GET['q']);

... and restoring it later when necessary (in my case immediately before a call to views_embed_view() after some ajax):

$_GET['q'] = isset($form_state['values']['q']) ? $form_state['values']['q'] : $_GET['q'];

Hi, Any progress on this issue. Seems to be a deal breaker for my ubercart site. How could I use the info above to place a quick fix in place. Where does the code go etc. Thank you.

Ajax Pagination error in the form, any solution for this issue...?

Please, leave this issue to the 8.x-dev version, at the moment. Bugs are first addressed in the developing version (Drupal 8 currently), and only when solved there, backported to previous versions if possible. Changing version will take it away from the radar of the core developers. Thanks.

I can confirm that in D8 this is still the case:

• have a pager in a form
• the form is Ajax enabled
• on first 'normal' call of the form, the pager links are referring to the route path of that form
• upon Ajax refresh of the form, the pager links are referring to the system.ajax route path
• when you click on any such link, you get an Ajax error

Working on a fix for #2182555: On Ajax-enabled forms with a pager, pager is disappearing on form validation error and on Ajax form reload, I think now I have clear why this happens, at least in D8.

1. when generating links, the theme functions get the 'href' to be used for the hyperlink from the current_path() function, which returns the path to the current route.
2. when getting the form first time, the route is set to the form's path, and the links are generated with the correct path.
3. if there is an Ajax enabled element on the form, the form and form state structures get cached; when an Ajax reload is executed, the form is rendered from the cached structures, and not 'rebuilt'.
4. on Ajax reload, the route used is the one of the Ajax controller (e.g. 'system/ajax') and not the one of the form.
5. so, the form is rendered with the links pointing to the current_path() that at that moment is 'system/ajax'.

At the moment we do not even have pagers on Ajax reload, so I believe #2182555: On Ajax-enabled forms with a pager, pager is disappearing on form validation error and on Ajax form reload needs to be fixed first. If the fix there gets accepted as a solution, we could use a similar model here, i.e. store (parts of) the current request in the cached $form_state, and during Ajax reload temporarily swap the Ajax route request with the original (cached) one, for the part of the Ajax processing that re-renders the form.

Yes, this is an issue. You can see this typically when you have triggered an AJAX command, execute some code like drupal_get_form, and return it in a modal. When executing from the AJAX callback, the path is almost always system/ajax because it is handling the command callback from the AJAX framework (in 7). Thus any dynamic paths, like pagers, break when replaced, with the wrong URLs. I am looking at this issue on my screen right now in a Drupal Commerce site I am building.

This issue was fixed for D8 by #2263569: Bypass form caching by default for forms using #ajax., by POSTing AJAX forms back to the form's URL and identifying differently the need to process them via AJAX. I have no idea if similar approach could be taken here, but this is now a D7 only issue.

As a quick fix I overrode theme_pager_link() to set the url of my AJAX-loaded pager to the page url instead of $_GET['q'] (which was system/ajax).

Is there anyway I can distinguished the first view/load of the form not triggered by a callback function?

Nice we get it solved on D8, another reason to use D8. :)

#12 for D7 !!

function employee_list() {
  global $user;
  $rows = array();
  $result = db_select('emp', 'e');
  $result->fields('e');
  if (isset($_GET['empcode']) && !empty($_GET['empcode'])) {
    $result->condition('empcode', $_GET['empcode']);
  }
  if (isset($_GET['name']) && !empty($_GET['name'])) {
    $result->condition('name', $_GET['name']);
  }
  if (isset($_GET['company']) && !empty($_GET['company'])) {
    $result->condition('company', $_GET['company']);
  }
  if (isset($_GET['department']) && !empty($_GET['department'])) {
    $result->condition('department', $_GET['department']);
  }
  $res = $result->extend('PagerDefault')->limit(5)->execute()->fetchAll();
  foreach ($res as $value) {
    $sid = $value->sid;
    $edit = l('edit', "employee/$sid/edit");
    $view = l('view', "employee/$sid/view");
    $rows[] = array($value->sid, $value->empcode, $value->name, $value->salary, $value->gender, $value->company, $value->department, $value->picture, $edit, $view);
  }
  $header = array('sid', 'empcode', 'name', 'salary', 'gender', 'company', 'department', 'picture', 'operation', 'operation 1');
  $table_element = array(
    '#theme' => 'table',
    '#header' => $header,
    '#rows' => $rows,
    '#prefix' => drupal_render(drupal_get_form('filter_form')),
    '#suffix' => theme('pager'),
    '#empty' => t('Your table is empty'),
  );
  return drupal_render($table_element);
}

I don't think this was fixed for 8:

#2504115: AJAX forms should submit to $form['#action'] instead of <current>
#2504709: Prevent _wrapper_format and ajax_form parameters from bleeding through to generated URLs

This definitely was not fixed in 8, unless I'm doing something wrong. My tablesort links are all broken when I render a table in an AJAX callback.