I noticed that although there is a static cache for the $script variable in url() (which holds either ‘index.php’ or ” depending on the used web server), it is not implemented properly. url() checks if the variable is empty. On Apache, this is always true and the check for other server version is run every time the function is called. Instead, it should check for isset() to only run the check once.
This can also be backported to 5 and 4.7.
| Comment | File | Size | Author |
|---|---|---|---|
| url-isset-script.patch | 653 bytes | kkaefer |
Comments
Comment #1
m3avrck commentedGreat catch!
Comment #2
dries commentedCommitted to CVS HEAD.
Comment #3
drummCommitted to 5.
Comment #4
killes@www.drop.org commentedcode has changed too much.
Comment #5
(not verified) commented