First, thanks for the great module!

Second, wouldn't it be better, for the sake of a small performance gain, to move the "show on teasers" and "content type" checks in hook_nodeapi closer to the case statement, so there is no need for all those variable gets and string concatenations if the button ain't going to be displayed.

My $.02 anyways :)

Comments

corbacho’s picture

corbacho commented

+1 about this. the if ($show) { should be as early as possible.

jerdiggity’s picture

jerdiggity commented
Assigned: Unassigned » jerdiggity
Status: Active » Fixed

Good call. Committed to dev release... Will be committed to next stable release along with a few other fixes.

Thanks!

:)

j

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.