E_ALL: Node object could be empty [#1173778]

You create an array for the token_replace_multiple() function that includes the $node parameter that you just loaded. The problem is that you always add the node even if it doesn't exist.

I get errors in the token, pathauto and other modules because of this small mistake.

What I suggest is that you add the $node parameter to the array only if the node was loaded. (see patch)

I specifically see the problem on a page created from a view, i.e. not a node and not a page that was added to a menu either.

Thank you.
Alexis Wilke

Comment	File	Size	Author
	google_analytics-3.x-tokens_without_node-6.x.patch	927 bytes	AlexisWilke

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

hass CreditAttribution: hass commented 31 May 2011 at 05:53

Dave have reviewed this code... What token version are you using and how can I repro this? I have never seen any warnings myself... What abou D7?

Comment #2

AlexisWilke CreditAttribution: AlexisWilke commented 31 May 2011 at 06:14

I don't use D7. 8-}

This only happens on pages that are not nodes (i.e. a view).

I have E_ALL turned ON as well to see all E_NOTICE errors, but the problem is that the hook_token_values() using the type 'node' can be overwritten by many and all expect a valid $node... Some other processes also generate an error (i.e. pathauto.)

If you want to get the error every time, use NULL instead of $node, then in token you get an error here:

function node_token_values($type, $object = NULL, $options = array()) {
  $values = array();
  switch ($type) {
    case 'node':
      $node = $object;
      // ERROR: $node->uid fails since $node is NULL or FALSE
      $account = db_fetch_object(db_query("SELECT name, mail FROM {users} WHERE uid = %d", $node->uid));

By changing your code with my patch, I avoid the problem by not putting the $node in the array when it does not represent a valid node (i.e. on a view.)

Thank you.
Alexis