Patch can save others the trouble of understanding what's the class name.

CommentFileSizeAuthor
#4 1169404-modal-button-example-docs-3.patch681 bytesamitaibu
modal-button-example-docs.patch589 bytesamitaibu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
CreditAttribution: amitaibu commented

btw, won't it be a better practice to use url():

  $form['url'] = array(
    '#type' => 'hidden',
    '#attributes' => array('class' => array('ctools-ajax-sample-button-url')),
    '#value' => url('ctools_ajax_sample/nojs/animal'),
  );

On a site I develop without the url() the url was not correct.

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented

Oh yes, url() probably is necessary at least for the base portion of the URL.

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented

Can you reroll the patch?

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
CreditAttribution: amitaibu commented
FileSize
1169404-modal-button-example-docs-3.patch681 bytes

Rerolled.

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
Status: Needs review » Fixed

Committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.