Closed (fixed)
Project:
Chaos Tool Suite (ctools)
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
23 May 2011 at 00:58 UTC
Updated:
4 Feb 2012 at 01:40 UTC
Jump to comment: Most recent file
Comments
Comment #1
Letharion commentedHello!
Unfortunately, this issue has remained open, without activity, for a very long time. I hope you can understand that between maintaining the module, work, and other obligations, the maintainers are very busy. This leads to not all issues being answered.
In order to figure out which bugs that are still present, I'm going over all low activity bug reports that has not been touched for 6 months, and marking them "Postponed, needs info". In many cases, I expect the bug to have been solved by a newer version of Panels..
If you can still reproduce this issue with the latest dev version of Panels, please just reset it's status to active, and we'll try to work it out. Please remember to post any new information that may be relevant, such as any attempts of your own at debugging.
Regards, Letharion
Comment #2
Letharion commentedA month has passed, and I'm going over the issue queue ones more. Some issues have been closed for other reasons, some re-opened, but this issue has remained silent for the past month.
Because of this, I'm doing a bulk close of a number off issues. I'm sorry that it happened this way, but the issue queue has had to few contributors, and to many questions.
Again, as said in the previous comment, feel free to re-open the issue by setting it to active, if you still need help.
Regards, Letharion.
Comment #3
videographics commentedI'm seeing a similar message with the very latest dev version of ctools and panels. I too have some empty text fields.
Undefined index: und in ctools_entity_field_content_type_render() (line 122 of example.com/sites/all/modules/ctools/plugins/content_types/entity_context/entity_field.inc
Comment #4
NimbyDagda commentedWe are also having the same issue where there are empty fields on entities which are being rendered with an alternative page layout. It is the same error message as above of
Undefined index: und in ctools_entity_field_content_type_render() (line 122 of /sites/all/modules/ctools/plugins/content_types/entity_context/entity_field.inc)
This seems to be an error in the code as it doesn't check to see if a field is empty before assuming there is an undefined locale entry.
We have temporarily fixed it locally by sticking in an isset() check, but as I am not familiar with exactly what is going on I don't know if that is all that is necessary for a fix.
i.e line 122 in our fixed version is now
$all_values = isset($entity->{$field_name}[$language]) ? $entity->{$field_name}[$language] : array();
Comment #5
franzkewd commentedSame errors as #4. Fixed those as per #4 too.
Cheers.
Comment #6
Letharion commentedWhat is the language setup on the sites that get this?
Comment #7
franzkewd commentedI have Drupal 7.10, both core Locale and Content Translation disabled, Panels 7.3.dev.
It was fine on the previous Ctools 7.1.dev. The error showed up upon upgrading to the recent Ctools 7.1.dev of Jan. 10, 2012.
Comment #8
Letharion commentedComment #9
merlinofchaos commentedOk, #4 and on are really not what this issue is about. People, please be more careful when comparing error messages. Just because they happen in similar parts of the code, these are really not at all the same error. So the issue has been effectively hijacked.
Plus, I should've checked out a patch a little more deeply that caused this.
Try this patch, please.
Comment #10
merlinofchaos commentedAlso, the line of code mentioned is totally in CTools. I know it's not always easy to get the module right but when you're actually looking at a line of code in a module, it should be easier.
Comment #11
renat commentedUnfortunately, patch from #9 gave other problems. Some pages with panels return WSOD after applying it. There are such message in the error.log:
It should be noted, though, that this WSOD appears only for English and Russian variants of the page, French version loads, but there are no content and bunch of error notices:
And in admin/reports section there are even more:
Drupal 7.10, Chaos tool suite 7.x-1.x-dev (2012-jan-10), Internationalization 7.x-1.3, Panels 7.x-3.x-dev (2011-Dec-07). English, French and Russian languages are enabled, English is default. All problematic pages have English as their source language. Cache cleared multiple times.
Comment #12
renat commentedTested patch from #9 against Chaos tool suite 7.x-1.0-rc1+80-dev (2012-Янв-16). Problems, mentioned in #11, are still there.
Comment #13
grossmann commentedI applied the patch of #9 but there seems to be an error on line 155 in the patch. I get the following error on the panel where the prepatch error of #4 happened.
And on a working panel (prepatch) I get this.
I have no other language than the default english in use.
grossmann-mcs
P.s. the original hijacked issue seems to be a duplicate of http://drupal.org/node/1153394
Comment #14
NimbyDagda commentedSame error, here.
I have temporarily fixed it by using the $entity_type rather than $clone_type since I assume thats what was intended. i.e.
replaced
$field_output = field_view_field($clone_type, $clone, $field_name, $field_settings, $language);
with
$field_output = field_view_field($entity_type, $clone, $field_name, $field_settings, $language);
Also sorry for my original post being the wrong issue, I was responding to the one directly above it which did have the same error as mine.
Comment #15
merlinofchaos commented#14: Thanks for the report!
Committed and pushed the fixed patch using $entity_type rather than $clone_type.