I have a node index that's kept in a feature. I have a search page associated to that node index (the search page isn't kept in a feature because that's not possible yet), and this search page sometimes magically just disappears from the site. I think, but I'm not sure, it happens when I revert changes to my node index using the features UI.

Let me know what more information I can provide.

CommentFileSizeAuthor
#2 1161532--discern-revert-delete.patch2.21 KBdrunken monkey

Comments

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented

Ah, yes, this might really happen when reverting changes to the index. I think hook_entity_delete() is called then, causing the search page to be deleted.
I'll ask fago about how to discern between reverting and deleting, thanks for reporting this problem!

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Title: Search page gets deleted » Discern between delete and revert in hook_*_delete()
StatusFileSize
new 1161532--discern-revert-delete.patch2.21 KB

Come to think of it, this also affects other parts, like facets and saved searches. However, as those can be made into features, too, that's probably not that much of a problem.
However, once we're at it, we should fix all problems at once.

Does the attached patch fix your problem?

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Version: 7.x-1.0-beta8 » 7.x-1.x-dev
Status: Active » Needs review
a1russell’s picture

a1russell commented

Yes, it does fix my problem. Thanks!

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Great, committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.