comment rss node feed displays for users who do not have 'access comments' permission [#1159788]

commentrss_node_feed_access() checks if the user can view the node, but not if the user has permission to view comments.

i'm also not sure if it makes sense to check if the user can view the node - i'm pretty sure that if the user can't view the node, then will hook_nodeapi(&$node, 'view') won't get triggered for them.

Comment	File	Size	Author
#1	check_comment_access-1159788-1.patch	670 bytes	firebus

Comments

Comment #1

firebus commented 17 May 2011 at 06:32

Title:	comment rss node feed displays for users who do not have access_comments permisson	» comment rss node feed displays for users who do not have 'access comments' permission
Status:	Active	» Needs review

Status	File	Size
new	check_comment_access-1159788-1.patch	670 bytes

added a user_access call to commentrss_node_feed_access().

didn't remove the node_access check - it looks like it matters when commentrss_node_feed_access is used as an access callback when actually displaying the feed, and isn't part of the nodeapi access check at all as i previously thought...