There are a few functions left over from when the facet functionality was stripped to use Facet API instead. Specifically, they are theme_apachesolr_unclick_link(), apachesolr_search_date_range(), theme_apachesolr_breadcrumb_date_range(), and apachesolr_search_vocabulary_content_types().

CommentFileSizeAuthor
#7 1159172-7.patch3.7 KBjpmckinney
#1 apachesolr-1159172-1.patch4.64 KBcpliakas

Comments

cpliakas’s picture

cpliakas commented
StatusFileSize
new apachesolr-1159172-1.patch4.64 KB

The attached patch strips out the functions.

cpliakas’s picture

cpliakas commented
Status: Active » Needs review

Marking as needs review...

pwolanin’s picture

pwolanin commented

At some point we were still using the unclick link - but perhaps no longer if the current search block is in facet API.

function apachesolr_search_vocabulary_content_types($vid) seems like it might still be useful in terms of the dependent facet code, or is this code obsolete?

cpliakas’s picture

cpliakas commented

It appears the Apache Solr unclick link is no longer used. Did a grep of the code and it is not called anywhere. Regarding the apachesolr_search_vocabulry_content_types($vid), a little bit of a different approach was taken to make the dependency stuff not focus solely around Taxonomy. See the 'referenced' operation in the FacetapiDependencyBundle::execute() method for the code that handles this type of dependency.

cpliakas’s picture

cpliakas commented
Issue tags: +Facet API integration

This is kinda sorta an integration issue. Being tag happy.

jpmckinney’s picture

jpmckinney commented
Status: Needs review » Fixed

Removes code that is never called. I approve.

jpmckinney’s picture

jpmckinney commented
Status: Fixed » Needs review
StatusFileSize
new 1159172-7.patch3.7 KB

Remove apachesolr_taxonomy_get_term and apachesolr_entity_callback and add comments referring to #1059372: References integration is broken. Should we just remove that old CCK code for now?

pwolanin’s picture

pwolanin commented
Status: Needs review » Fixed

well, I'd rather fix it soon.

Committed you patch for now.

Automatically closed -- issue fixed for 2 weeks with no activity.