On .../admin/store/orders//edit there is a list of order lines with a red button (and white cross) on the left. I suppose it stands for line deletion, but pressing it has no effect.
Instead, with the same button I can remove a shipment line for example.

CommentFileSizeAuthor
#4 remove_product.patch648 bytestr

Comments

tr’s picture

tr commented
Status: Active » Closed (cannot reproduce)

I can't reproduce the problem - it works fine for me. I suppose there could be a JavaScript error caused by conflict with some other module you have installed. I recommend using Firebug to see if that's the case.

mandreato’s picture

mandreato commented
Status: Closed (cannot reproduce) » Active

Thanks for the suggestion !
I've used Firebug to trap the error and it asserts that the following line is generating a "missing ) after argument list" exception:

remove_product_button('Rimuovere il prodotto dall'ordine?', this.id);

I think that it's due to the apostrophe in "Rimuovere il prodotto dall'ordine?" which is the italian translation for "Remove the product from order?".

Is it possible to fix the code in order to manage strings with apostrophes in that statement ?

tr’s picture

tr commented

Yes, good job finding that! I'll post a patch later today.

tr’s picture

tr commented
Status: Active » Needs review
StatusFileSize
new remove_product.patch648 bytes

Try this.

mandreato’s picture

mandreato commented
Status: Needs review » Reviewed & tested by the community

The patch @4 does work.
Thank you TR !

tr’s picture

tr commented
Status: Reviewed & tested by the community » Fixed

Committed the fix in #4, and also changed one other instance I found in uc_google_checkout() that had the same potential problem.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.