Closed (fixed)
Project:
Node clone
Version:
5.x-1.0-beta
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
3 Feb 2007 at 17:31 UTC
Updated:
9 May 2014 at 01:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
hass commentedtake this second one please. i changed some wrong paths in the "de.po" file, while i took the "fr.po" file that seems not clean...
Comment #2
pwolanin commentedIs this for 4.7.x or 5.x?
Comment #3
hass commentedshould really work for both versions, but as basis i used the fr.po from the 4.7.x-1.1.
Comment #4
pwolanin commentedThanks.
I committed this into the 4.7.x version- please confirm that it works for 5.x
Comment #5
hass commentedok, i worked on this issue with node_clone 5.x-beta1.
Attached you get:
1. a minor translation Bugfix for node_clone.module (must be applied - or the POT and PO file is wrong)
2. the po/node-clone.pot file for everyone to help translating the module
3. the po/de.po file with the german translation for node_clone 5.x
Comment #6
pwolanin commentedWhy did you use @ in the translation? I prefer % so that I get the automatic theme('placeholder').
Please look at the revised patch (fr, de, and pot)
Comment #7
pwolanin commentedSlightly better patch, fixed module name capitalization
Comment #8
hass commentedA "%" adds in Drupal 5 a
<em></em>around the text what "@" doesn't do.You have changed this for other strings like "Clone of @title" in clone.module. I saw you changed all other strings in the clone.module, except the one string i changed. i thought this one was only missed on the transition from Drupal 4.7.x to Drupal 5... so what i've done is - only restored the old behavior.
You FR translation file contains everywhere "%" where you have an "@" in the modules code. this one will therefor not work...
"%s: ré-initialiser les options de publication" must be "@s: ré-initialiser les options de publication"
Comment #9
pwolanin commentedYes, I want the
<em>in the case of the node title for the confirm form, but not for when generating the cloned node title.Comment #10
hass commentedLooks like you have "destroyed" the node-clone.pot file while you edited it by hand... do this very carefully in future and do a poedit crosscheck, please. The fault was the changed string "clone module" to "Clone module" in the last lines and there was another "Clone module" inside the file (line ~26). This caused errors in poedit while duplicate strings existed and makes it impossible to update the language files from .pot and additional .pot cannot saved then. i fixed this now.
Additional i fixed the open bug with % and @ in the FR version (except the %title) and some path errors in the FR version. Additional we should ask Christian Quest to have a look to the new strings like "clone module". I don't think this is correctly translated. I checked them with a dictionary and his translation seems to mean "clone content"... but i don't speak French... maybe i'm wrong.
Comment #11
pwolanin commentedThanks for fixing it- obviously I don't have a lot of expertise with translation files!
committed the patch to HEAD
Comment #12
pwolanin commentedI'm not done yet with the code on the 4.7-2.x and 5.x-2.x branches: http://drupal.org/node/110294
But at least one string is going to be changed to fit the altered functionality
Comment #13
hass commentedno problem, we will update short befor you are going to release... ok?
Comment #14
hass commentedplease apply this patch after the other german patch. i missed to set the plurals-form string.
Comment #15
hass commentedupdate has been committed.
Comment #16
(not verified) commented