Opera and IE are finally into gradients. I reworked the gradients code so it should be safe for now and the future. Based on http://ie.microsoft.com/testdrive/Graphics/CSSGradientBackgroundMaker/De...

:D

Hopefully this will be my first D8 patch :p

This is an important patch for opera. Not that much for IE because IE10 will be released next year.

ps: also need to be fixed in D7
ps2: didn't test it so crossbrowser testing is needed

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aspilicious’s picture

O comes before S

aspilicious’s picture

Tested my own patch. I have background gradients on:

- chrome 11
- firefox 4
- IE 10 (platform preview)
- opera 11.10

Will NEVER work on:
< IE 10
< opera 11.10
Please don't put this on "needs work" if you're testing with one of those

amateescu’s picture

This patch was already available in #844728: Add support for linear gradients on IE. I don't see why you couldn't add the Opera bits over there :)

Jeff Burnz’s picture

Priority: Major » Normal

I don't think this fits in with #844728 because that discussion is about adding filters which is a whole argument in itself which I do not see as being resolvable to be honest.

This issue is merely adding to the existing browser extensions as they become available, and there is no harm in that, so this is essentially a no-brainer. We do need this is in asap and back-port it asap as well so its in the next point release of D7.

tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community

I agree with Jeff, this should be kept separate from #844728: Add support for linear gradients on IE and should definitely go in.

amateescu’s picture

Issue tags: +Needs backport to D7

I also disagree with myself in #3 :) I was too tired when I posted that and didn't really understand what this issue was all about.

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 7.x and 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.