The Webform integration is missing a good number of Webform components. Worse yet, when the field is not supported by Form Builder, it is entirely lost upon saving.

CommentFileSizeAuthor
#2 form_builder_webform_date-d6.patch17.18 KBquicksketch
#2 form_builder_webform_date-d7.patch16.63 KBquicksketch
#1 form_builder_webform_date-d6.patch17.17 KBquicksketch
#1 form_builder_webform_date-d7.patch16.6 KBquicksketch

Comments

quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Needs review
StatusFileSize
new form_builder_webform_date-d7.patch16.6 KB
new form_builder_webform_date-d6.patch17.17 KB

Here's a start that adds support for the date component. It generalizes the useful utility function for pulling out file component forms so it can be used for any advanced component.

I'm going to wait on this patch because the Webform integration is all messed up right now because it uses the default title display of "above" instead of the correct "before", which prevents anything from being shown.

quicksketch’s picture

quicksketch
he/him
commented
StatusFileSize
new form_builder_webform_date-d7.patch16.63 KB
new form_builder_webform_date-d6.patch17.18 KB

I was having trouble testing this new component until I realized that #1149734: Webform integration uses non-existant Webform label options was getting in my way. Now tested and I've applied this patch (rerolled to work with #1149734) as a start to getting our advanced components working again.

quicksketch’s picture

quicksketch
he/him
commented
Title: Webform missing advanced components (date, time, grid) » Webform missing advanced components (add support for date component)
Status: Needs review » Fixed

I've committed these patches plus an icon for the date component. Let's call this issue good now that it's had a commit. Followups:

#1149774: Webform integration missing grid component
#1149772: Webform integration missing time component

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.