Closed (won't fix)
Project:
Views Bulk Operations (VBO)
Version:
6.x-1.x-dev
Component:
Actions
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
2 May 2011 at 11:30 UTC
Updated:
17 Oct 2013 at 02:46 UTC
Jump to comment: Most recent file
Comments
Comment #1
gnindl commentedChange status
Comment #2
infojunkieHiding the drop down without explanation would confuse users as much or more than an empty selector. IMO there could be a message instead of the drop down saying something like "No operations found".
Re: moving the single operation to the top, that's already implemented in the latest dev.
Comment #3
infojunkieRenaming title to main issue.
Comment #4
fluxsauce commentedI agree with gnindl and appreciate the patch; I have a view that has role-based bulk operations, and some roles do not have access to those operations. Rather than giving someone a message that they don't have access to any roles or maintaining two, essentially duplicate versions of the same view, it's better to not show the options at all.
As a compromise, make it an option:
Comment #5
chintan4u commentedHello Guys....!
I am also facing same problem.
Like FluxSauce ... I want to show VBO only to Admin & editor role .
I don't want show drop-down to normal users.
How to achieve this in correct manner ("the drupal way")
Comment #6
bojanz commentedThe patch in the original post needs to be rerolled to include infojunkie's feedback from #2. That's the "drupal way"
Comment #7
gnindl commentedA) I removed the code for moving a single operation to the top as it has been done in elsewhere
B) IMHO a message like "No operations found" would be very confusing for an END USER (If there are no operations available why the heck should you display anything?). It's just irritating. I see that it would be confusing for and administrator or developer if no message is displayed (module not enabled, code not working etc.). I think the end user's requirements should take precedence. Further I don't think showing an empty selector is a best practice for UX design.
Comment #8
Esculap commentedI'm having the same problem in drupal 7
Comment #9
infojunkieThe patch in #7 is working well, but now we get a series of checkboxes that do nothing - since the action drop-down has been removed. I don't think that's good UX because the user is confused as to whether the actions are intentionally hidden or he's seeing a bug.
The comment in #5 hints that maybe the view should revert to a normal table style if there are no actions. Or just remove the checkboxes column.
Comment #10
Bevan commentedThere are patches for this same feature but for versions
7.x-3.x-devand7.x-3.x-rc1at #1618474: Hide operations selector & checkboxes if no operation available.Comment #11
jyee commentedThe patch in #7 didn't work for me against the latest dev (commit 6aaa911 - 3 May 2012). Notably, it doesn't apply cleanly and when manually adding the if statement, it hid the VBO form along with the entire view.
I've attached a patch that keeps the form intact and simply sets the access to false, so that it isn't rendered (per the Form API). Note this isn't a solution, it's just a workaround, and it does not address the checkbox issue, so I won't even bother changing the status.
Comment #12
balagan commentedThere is a module for it, just 2 days old https://drupal.org/project/vbo_hide
Comment #13
Bevan commentedNotes:
Comment #14
bojanz commentedI'm not committing anything to D6 at this point. It's dead, Jim.
So let's leave it to infojunkie to decide.
Comment #15
infojunkieI probably won't fix this unless there's an urgent (i.e., commercial) need. Contact me privately if this is the case.
Comment #16
Bevan commentedI alone have patched 2 or 3 commercial websites with this patch. This makes their upgrade path difficult.
Comment #17
infojunkieBevan, which patch are you referring to, #7 or #11?
Comment #18
Bevan commentedProbably both. I don't have access to check anymore.