Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The tweet button is output regardless of settings
Comment | File | Size | Author |
---|---|---|---|
#7 | show_button_in_node_teasser-1139470-7.patch | 887 bytes | wolmi |
Comments
Comment #1
realityloopI tried to create a patch but couldn't navigate through your git repo succesfully.. the following changes to tweetbutton_node_view fix the issue:
Comment #2
petednz CreditAttribution: petednz commentedhi - can you clarify if this issues is about the 'Full View' versus "Teasers' settings - or is that when setting for node types here admin/config/tweetbutton/node it seems to me that regardless of setting Tweet to be unchecked for several content types, new content of that type ends up with a Tweet button when I don't expect it. Happy to make a new ticket if yours is 'teaser and node' settings rather than 'teaser or node' settings ;-)
Comment #3
realityloopHi Peter.. I can't remember to be honest. :)
From memory, the problem that my change fixed was to only display the tweet button on node types it was set for, previously it output on all node types I think.
Comment #4
petednz CreditAttribution: petednz commentedi think i agree - but i hoped it may also resolve fact that the tweet button is coming through on Teasers - whereas Facebook like doesn't - but guess I will trawl the issues queues - though may both are working as intended - they just have different starting points
Comment #5
protools CreditAttribution: protools commentedsub
Comment #6
BenK CreditAttribution: BenK commentedSubscribing
Comment #7
wolmi CreditAttribution: wolmi commentedThe solution proposed on #1 is not exact.
I posted this patch on http://drupal.org/node/1272424 but I think is better to post here.
the result will look like this:
Comment #8
chia CreditAttribution: chia commentedI have tested it for the latest 7.x-1.x and it seems to be fixed.
reopen this issue if this problem persists