When logged out apt_plugin throws an error for missing the $domain value of casaa_get_global_values.

Error Message:
warning: Missing argument 2 for casaa_get_global_values(), called in apt_plugin/apt_plugin.module on line 566 and defined in casaa/casaa.module on line 342.

Issue doesn't happen when logged in.

Comments

cntlscrut’s picture

cntlscrut commented

This was happening for both the apt and yca plugins inside of hook_block. I was able to fix those, but, there may be some other instances where the second parameter for the domain is not being populated. More than likely in the global forms as those were the last to be ported to be across domains.

So, i'll keep searching for those lingering calls within the rest of the plug-ins.

cntlscrut’s picture

cntlscrut commented
Status: Active » Fixed

For the core framework, changed the function declaration to casaa_get_global_values($plugin, $domain = 0)

That clears the whole issue. What we'll have to do is go through the plugins and make sure that each call is setting the right domain for which it's being called.

cntlscrut’s picture

cntlscrut commented
Status: Fixed » Needs work

switched to needs work status as there isn't a "ready to commit" status. I've fixed most of the cases just need to commit the changes.

cntlscrut’s picture

cntlscrut commented
Status: Needs work » Fixed

changes have been committed to perforce repo. Will update git after other changes have been gathered.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.