Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I haven't checked if a fix has been committed - so my apologies if it has..
At admin/structure/types/manage/%type/display, after clicking on the settings button for the collection, the last sentence reads:
"If enabeld adn the add link is shown, the field description is shown in front of the add link."
Comment | File | Size | Author |
---|---|---|---|
#7 | typo-1138168.patch | 678 bytes | Barrett |
#2 | typo-1138168.patch | 678 bytes | Barrett |
Comments
Comment #1
AtomicTangerine CreditAttribution: AtomicTangerine commentedYes, if the developers could correct that line (line 687 in .module) to "If enabled and the add link...."
Excellent module by the way, you all are awesome :)
Comment #2
Barrett CreditAttribution: Barrett commentedPatch attached
Comment #4
AtomicTangerine CreditAttribution: AtomicTangerine commentedBarett, a paren ran away from the function signature is all. idk how to do a patch, but I'll save you the 30 seconds and bold it so you can put up another :) thanks!
@@ -684,7 +684,7 @@ function field_collection_field_formatter_settings_form($field, $instance, $view){
'#type' => 'checkbox',
'#title' => t('Show the field description beside the add link.'),
'#default_value' => $settings['description'],
- '#description' => t('If enabeld adn the add link is shown, the field description is shown in front of the add link.'),
+ '#description' => t('If enabled and the add link is shown, the field description is shown in front of the add link.'),
);
return $form;
}
Comment #5
Barrett CreditAttribution: Barrett commented#2: typo-1138168.patch queued for re-testing.
Comment #6
Barrett CreditAttribution: Barrett commentedI don't really know why the test is failing, but the patch applies cleanly. That the location line is missing the closing paren and opening bracket don't seem to matter.
I've requested re-testing of the patch. It appears to me that a test elsewhere in the module is failing.
Comment #7
Barrett CreditAttribution: Barrett commentedDamnit. No, I'm just an idiot. The previous patch is rolled against dev. Here's one for beta-1
Comment #9
tim.plunkettNot sure why the tests are failing for a typo fix.
Comment #10
Barrett CreditAttribution: Barrett commented#7: typo-1138168.patch queued for re-testing.
Comment #11
Barrett CreditAttribution: Barrett commentedI've heard a rumor the test bot was having an off-day yesterday.
Comment #13
fagothe test-bot is not able to handle the entity api dependency (any more), so it fails. Patch is fine, thanks committed.