Closed (fixed)
Project:
Field collection
Version:
7.x-1.0-beta1
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
25 Apr 2011 at 22:00 UTC
Updated:
25 Aug 2011 at 08:32 UTC
Jump to comment: Most recent file
Comments
Comment #1
AtomicTangerine commentedYes, if the developers could correct that line (line 687 in .module) to "If enabled and the add link...."
Excellent module by the way, you all are awesome :)
Comment #2
barrett commentedPatch attached
Comment #4
AtomicTangerine commentedBarett, a paren ran away from the function signature is all. idk how to do a patch, but I'll save you the 30 seconds and bold it so you can put up another :) thanks!
@@ -684,7 +684,7 @@ function field_collection_field_formatter_settings_form($field, $instance, $view){
'#type' => 'checkbox',
'#title' => t('Show the field description beside the add link.'),
'#default_value' => $settings['description'],
- '#description' => t('If enabeld adn the add link is shown, the field description is shown in front of the add link.'),
+ '#description' => t('If enabled and the add link is shown, the field description is shown in front of the add link.'),
);
return $form;
}
Comment #5
barrett commented#2: typo-1138168.patch queued for re-testing.
Comment #6
barrett commentedI don't really know why the test is failing, but the patch applies cleanly. That the location line is missing the closing paren and opening bracket don't seem to matter.
I've requested re-testing of the patch. It appears to me that a test elsewhere in the module is failing.
Comment #7
barrett commentedDamnit. No, I'm just an idiot. The previous patch is rolled against dev. Here's one for beta-1
Comment #9
tim.plunkettNot sure why the tests are failing for a typo fix.
Comment #10
barrett commented#7: typo-1138168.patch queued for re-testing.
Comment #11
barrett commentedI've heard a rumor the test bot was having an off-day yesterday.
Comment #13
fagothe test-bot is not able to handle the entity api dependency (any more), so it fails. Patch is fine, thanks committed.