I haven't checked if a fix has been committed - so my apologies if it has..

At admin/structure/types/manage/%type/display, after clicking on the settings button for the collection, the last sentence reads:

"If enabeld adn the add link is shown, the field description is shown in front of the add link."

CommentFileSizeAuthor
#7 typo-1138168.patch678 bytesBarrett
#2 typo-1138168.patch678 bytesBarrett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

AtomicTangerine’s picture

Yes, if the developers could correct that line (line 687 in .module) to "If enabled and the add link...."
Excellent module by the way, you all are awesome :)

Barrett’s picture

Status: Active » Needs review
FileSize
678 bytes

Patch attached

Status: Needs review » Needs work

The last submitted patch, typo-1138168.patch, failed testing.

AtomicTangerine’s picture

Barett, a paren ran away from the function signature is all. idk how to do a patch, but I'll save you the 30 seconds and bold it so you can put up another :) thanks!

@@ -684,7 +684,7 @@ function field_collection_field_formatter_settings_form($field, $instance, $view){
'#type' => 'checkbox',
'#title' => t('Show the field description beside the add link.'),
'#default_value' => $settings['description'],
- '#description' => t('If enabeld adn the add link is shown, the field description is shown in front of the add link.'),
+ '#description' => t('If enabled and the add link is shown, the field description is shown in front of the add link.'),
);
return $form;
}

Barrett’s picture

Status: Needs work » Needs review

#2: typo-1138168.patch queued for re-testing.

Barrett’s picture

Status: Needs review » Needs work

I don't really know why the test is failing, but the patch applies cleanly. That the location line is missing the closing paren and opening bracket don't seem to matter.

I've requested re-testing of the patch. It appears to me that a test elsewhere in the module is failing.

Barrett’s picture

Status: Needs work » Needs review
FileSize
678 bytes

Damnit. No, I'm just an idiot. The previous patch is rolled against dev. Here's one for beta-1

Status: Needs review » Needs work

The last submitted patch, typo-1138168.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Reviewed & tested by the community

Not sure why the tests are failing for a typo fix.

Barrett’s picture

#7: typo-1138168.patch queued for re-testing.

Barrett’s picture

I've heard a rumor the test bot was having an off-day yesterday.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, typo-1138168.patch, failed testing.

fago’s picture

Status: Needs work » Fixed

the test-bot is not able to handle the entity api dependency (any more), so it fails. Patch is fine, thanks committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.