Delete invite not working

The problem is in the fix of the extra EM's issue, that obviously must have gone a bit too far :)

The line 505 in function invite_delete($email) before was
$email = urldecode($email);
and now is:
$email = rawurldecode(urlencode($email));

The intention (I guess) was to deal with new tagging using '@' character, but unfortunately it also changes legitimate emails (from e.g. xyz@example.com to xyz%40example.com).

Changing the mentioned line back to the old form fixes that problem
The question (I do not know answer for) is - does it not cause some issues elsewhere?

BTW, also, in the function function _invite_settings() the tags like %site, %inviter etc. are still old. The line 144 should now read:
'#description' => t('Use the following placeholders; @site, @homepage, @join_link, @message, @inviter'),

I do not commit any changes to CVS, because I do not yet know how that works :)

Pawel

You can't commit changes without a CVS account and even then you need the maintainer (me) to add you to thge project. Th enornal route rather than spelling it out liek you did is to supply a patch on this issue (attach as file). If it's ok, I'll commit the patch. That's how it works, random people don't just "commit" directly to CVS.

Please attach a patch and I'll get it applied. I'm afraid I don't have time right now to re-work it from your worded solution. Please note, if supplying a patch pleaes supply one for Drupal-5 and Drupal-4-7 is possible.

Cheers;
--Andy

http://drupal.org/diffandpatch

Please change the status from postponed to "patch (code needs review)" after posting patch. Thanks

http://drupal.org/cvs?commit=53950

I just installed this module and found I wasn't able to delete an invite. Some research dug up http://drupal.org/node/101208 (can't delete users with "+" in the email address). It looks like the fix for this bug backed those changes out. Any thoughts on a fix for the original issue?

http://drupal.org/node/101208 re-opened

Line 505 in my invite.module file reads:

$email = urldecode($email); // $email = rawurldecode(urlencode($email));

I deleted the part after the first semicolon, so now it reads this:

$email = urldecode($email);

but I still can't delete someone who is listed as "joined."

Sry I had to reopen this so someone would pay attention.

Nevermind, I figured it out. Line 505 should read:

$email = urldecode($email); // $email = urldecode($email);

I'm easily confused by php.