1) the process of finding patterns that are longer than the allowable length shouldn't truncate the values. Truncating the values loses important information, while the current warning just warns the user of the problem and let's them decide how to truncate.
2) The process of finding patterns that are longer than the allowable length looks at component instead of max, it seems. Steps to repeat: leave total length long, set component length short, patterns will be marked as bad even if they would work.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | remove_length_checking.patch | 1.15 KB | greggles |
Comments
Comment #1
gregglesWell, I'm starting to think that this whole checking system is somewhat dangerous because it can result in losing the information about your patterns. Better would be to warn about the potential problem. But even then the [uid] value takes 5 characters to represent, but can sometimes be just 1 character long, so the test is weak at best.
I think the best solution is just to remove the checking altogether.
Attached patch does just that.
Comment #2
gregglesComment #3
gregglestest for killes.
Comment #4
gregglesI think I already said this, but this is now committed/fixed.
Comment #5
(not verified) commented