invoke hook_url_outbound_alter

Patch attached

Yeap, I had the same issue with PURL in D6, and it gave me headaches. I stopped using it since it gave me more trouble than solutions, although I would love to get it fixed.

I submitted a hackis patch in #346911-83: Redirect Loop and custom_url_rewrite ignored a while ago where I found a solution for D6, but it really is hackis

Basically what it does is it emulates the way PURL modifies the URL before making the comparison. it works, but I don't like it. globalredirect_clean_path()

For D7, I think hook_url_outbound_alter needs to be invoked in more places for it to work.

Cheers

Yeap, that is correct for D7, but since in D6 custom_url_rewrite_outbound wasn't a hook (bump) there was no way for module to alter URL's in a consistent way, there was no hook for it, so one had to be cerated. In D7 we have HOOK_url_outbound which should solve the problem.

BTW, you might want to check the patch in #346911-85: Redirect Loop and custom_url_rewrite ignored it was a cleaner version.
Anyway, if you check my patch, you'll see that I was calling the function I created in 3 places, which is where we need to get the clean verison of the url. I have no installation of PURL anywhere nearby to thoroughly test, but I'm pretty sure that if you modify the D7 version to call HOOK_url_outbound where I was calling my PURL fix function, it should work.

Hello

The patch is for D7 and fixes redirects in plenty of situations, like when using http://drupal.org/sandbox/davereid/1078890 which is a sandbox for the D7 version of http://drupal.org/project/subpath_alias

It still needs some work to fix the problems with PURL, but if someone tries what I mention in number #5 I think it would fix purl problem.

Just to make sure we are all in the same page:

1. In d6 there was no hook to modify urls, but there was the posibility for developers to implement custom_url_rewrite_outbound, but it could only be used once across the whole site so modules couldn't implement it.
2. The D6 version of the module was calling custom_url_rewrite_outbound() which was fine.
3. The D7 version was still calling it, which was wrong, there is now a hook in D7 hook_url_outbound_alter which is what we need to invoke now. My patch fixes that. It removes the call to custom_url_rewrite_outbound which is unnecessary and it invokes the hook.
4. The HOOK is being called the way it should be called, the same way url() does
5. The patch I link to in #5 and #3 fix the redirect problem in D6, but they do it in a really hakish way, BECAUSE there was no hook to do it in D6.
6. In D7 the hook should, in theory, be implemented in PURL and any other module that modifies the url, and if called by Global Redirect, redirect issues should be fixed.

@Kiphaas7 Did you actually read the patch? And the issue? My patch implements drupal_alter('url_outbound') in the same way url() does. And it does fixes a problem. Also, correct me if I'm wrong, but registering a hook is not the same as invoking it. Here I'm not registering it, I'm invoking it.

Cheers