there's an admin setting for the default issue state to use. however, there are still some places in the code where this default setting isn't used, and sid==1 is hard-coded. related to (but not duplicate with) http://drupal.org/node/27865

CommentFileSizeAuthor
#1 issue_sid.patch1.31 KBhunmonk

Comments

hunmonk’s picture

hunmonk commented
Status: Active » Needs review
StatusFileSize
new issue_sid.patch1.31 KB

i *think* this handles all the rest of the hardcoded cases like these. there are a couple of queries in the mailhandler code that hard code sid 1 and 2, but i'm guessing those need to remain as is.

dww’s picture

dww
we/he/they
commented
Status: Needs review » Reviewed & tested by the community

those 2 are certainly worth fixing. code looks fine and simple testing still works. i'm not sure that's everything, and i don't have time to look closely now, but feel free to commit this patch and set this issue back to active. thanks.

hunmonk’s picture

hunmonk commented
Status: Reviewed & tested by the community » Needs review

i'd rather catch them all in one patch, thanks. :)

pretty sure that there aren't any more, but feel free to run a grep at your leisure and confirm. i'll wait for somebody to do that and RTBC before i commit.

hunmonk’s picture

hunmonk commented
Status: Needs review » Postponed (maintainer needs more info)

applied current to 4.7.x-1.x, 4.7.x-2.x, 5.x-1.x.

there are a few spots where it's unclear whether the hardcoded vals should be replaced, so i'm leaving this open for now.

hunmonk’s picture

hunmonk commented
Status: Postponed (maintainer needs more info) » Fixed

this issue is done as far as i know

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.