Currently it doesn't return the rendered fields on the first time.

CommentFileSizeAuthor
#14 fix_rendered_fields_notice-1124098-14-D6.patch426 bytespdrake
#8 1124098-followup.patch556 bytesbojanz
#1 1124098-render_fields-return.patch1.28 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Needs review
FileSize
1124098-render_fields-return.patch1.28 KB

What about this patch.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Commited to 6.x-3.x,, 7.x-3.x because it's helpful and it was useful for writing tests.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Fixed

Update status.

dystopianblue’s picture

dystopianblue CreditAttribution: dystopianblue commented
Status: Fixed » Needs review

This patch is causing issues in the calendar module (see: http://drupal.org/node/1158518) when there are no results returned. I suggest adding $this->rendered_fields = array(); to line 310.

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
Status: Needs review » Active

Please read what the statuses mean.

Steven.Pescador’s picture

Steven.Pescador CreditAttribution: Steven.Pescador commented

subscribe

BrightBold’s picture

BrightBold
she/her
Primary language English
Location Boston, MA
CreditAttribution: BrightBold commented

subscribe.

bojanz’s picture

bojanz CreditAttribution: bojanz commented
Status: Active » Needs review
FileSize
1124098-followup.patch556 bytes

Just saw this notice as well. The attached patch should do the trick.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Fixed

Just realized that my local php version shows strict errors but no notices. what a fail.

Thanks for providing a patch bojanz. Commited.

Druper’s picture

Druper CreditAttribution: Druper commented

Is it necessary to apply both patches or just #8, "1124098-followup.patch"?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Just #8 but it's already in and will be in DEV at the latest tomorrow.

Druper’s picture

Druper CreditAttribution: Druper commented

Cool, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

pdrake’s picture

pdrake CreditAttribution: pdrake commented
Version: 7.x-3.x-dev » 6.x-3.x-dev
Status: Closed (fixed) » Needs review
FileSize
fix_rendered_fields_notice-1124098-14-D6.patch426 bytes

The followup fix in #8 needs to be applied to 6.x-3.x-dev as well. Attached is a patch.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Fixed

Thanks for reopening. Just committed the patch to 6.x-3.x as well.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.