Hi,

I noticed that if I re-arrange the referral sources using (Referral Sources > List) it will arrange them correctly in the drop down, however it does not update the IDs in the database and displays the incorrect referral.

Ex:
A changed to second in list
B changed to first in list
C Left at C

If B is selected, it will show A (because ID is still being recognized to point to A)
So i would need to go into the MySQL DB and change them to the correct IDs for the order to stay.

Thanks,
Josh

CommentFileSizeAuthor
#1 1124096.patch670 bytesstennie

Comments

stennie’s picture

stennie CreditAttribution: stennie commented
Status: Active » Patch (to be ported)
StatusFileSize
new 1124096.patch670 bytes

There's a serious bug in the code that creates the 'grouped' select box ('flat' display appears OK).

It's using array_merge() to combine options, which has the documented side effect of renumbering numeric keys starting from 0. Essentially the IDs for grouped select will only match if you've never reordered or deleted sources :(.

Fix attached.

Cheers,
Stephen

stennie’s picture

stennie CreditAttribution: stennie commented
Priority: Major » Critical

It's actually a critical bug, as invalid IDs defeat the purpose of the module.

Cheers,
Stephen

Offlein’s picture

Offlein CreditAttribution: Offlein commented

Bummer - this module is Abandoned. I reported it, but don't have the time to maintain it, myself. :(

izzysanime’s picture

izzysanime CreditAttribution: izzysanime commented

I never got an email you replied, I think your patch fixed the issue. I will test it out for a few more days.

I really appreciate the fix.

Thanks,
Josh

dandaman’s picture

dandaman CreditAttribution: dandaman commented
Status: Patch (to be ported) » Reviewed & tested by the community

Thanks. That fixed an issue for me! A very helpful patch that should be committed!