Allow placeholders in search page paths

Looks like a reasonable start.

Initial comments:

drupal_uninstall_schema('apachesolr_search') is automatic in 7

db_query_range() is not needed - since name is the primary key

you don't want to mess with hook_search_page - you want to define a new page callback

looks pretty good. We should probably use %menu_tail instead of % for the router items though.

We should also consider at least a few simple ways to add default filters.

I've committed #7 locally and working to simplify it in places plus add default filters.

my hangup now is getting this error when trying to use a non-default server:
"Fatal error: Call to a member function build() on a non-object in modules/facetapi/facetapi.abstract.inc on line 760"

I pushed up a feature branch for testing:

http://drupalcode.org/project/apachesolr.git/tree/refs/heads/1122186-sea...

So, thinking about other things to resolve:

it's clear we need to make it so that the sever ID cannot be changed once it's established. Letting it change will break facet API blocks and these pages.

However, we still have to handle the case of server deletion - so we probably need to define hooks for that.

I would like to add some support for very simple URL-based filters. The luceneapi code I deleted because it was way too complex.

What I'd want to see is basically allow the user to specify one % in the path. For the 1st pass we could just have a textfield to type in the field name to match. For a better UX, I'd offer a select list at least for common fields - the select list would let us do something like taking the use NAME in the url as part of the path, and then looking up and filtering by the uid. Same for terms. Also, by know which field we have we can do things liek setting the term name as the page title.

For cases like overriding taxonomy pages, I'd like a toggle to switch between having %menu_tail take the keys in and instead using ?keys= I think that would make it less confusing in terms of the term feeds.

Once those things are working, I think we

There are a variety of options here. Setting an empty value for the server ID and maybe having a "<disabled>" option in the server select list might work as part of that? Otherwise there is no way to disable bu not delete a page.

Putting in a major rework of the way we handle caching the current query, etc. That was required to avoid having fatal errors when 2 different servers had facetapi facets enabled.

Attached is the net diff to the main branch. Also includes API fixes to the MLT code.

ok, did a little local rebase and merged and pushed up 2 commits to the main branch. Let's continue work based on that.

Somehow I missed committing part of that patch. Odd. It should all be there now.

I also committed changes to make the server ID immutable.

back to active for further improvements

Supporting the use of one % placeholder in the path as an argument was the one planned addition feature.

With that we'd also (ideally) support making searches use ?keys= for keyword searches, rather than always using %menu_tail (I thought this would be preferable for e.g. taxonomy pages)

The goal, essentially, is to be able to remove the taxonomy module totally by being able to make a custom search page that takes a tid argument.