Since we want to use Facet API we need to start ripping out the facet block code.

CommentFileSizeAuthor
#10 RemoveMoreVariables.patch619 bytesjpmckinney
#7 1121170-7006_doc-6.patch968 bytespwolanin
#5 1121170_5_7006_doc.patch366 bytesscor

Comments

pwolanin’s picture

pwolanin commented

pushed two commits to a feature branch:

http://drupalcode.org/project/apachesolr.git/commit/fb5de25878c919d49447...
http://drupalcode.org/project/apachesolr.git/commit/20563da8921d63c9a07b...

pwolanin’s picture

pwolanin commented

That seems to be working ok - merged into the main branch. and made another commit:

http://drupalcode.org/project/apachesolr.git/commit/5b12986

pwolanin’s picture

pwolanin commented

Made a couple more commits -
http://drupalcode.org/project/apachesolr.git/commit/4b0b87e
http://drupalcode.org/project/apachesolr.git/commit/1318c10

This is pretty much done except that we need to remove the currentsearch block and rebuild it potentially in Facet API module

pwolanin’s picture

pwolanin commented
Status: Active » Fixed
scor’s picture

scor commented
Status: Fixed » Needs review
StatusFileSize
new 1121170_5_7006_doc.patch366 bytes

apachesolr_update_7006 is missing a title and appear as a mysterious update when running drush updb (or update.php I suppose).

pwolanin’s picture

pwolanin commented

Yes, probably more variables that need to be removed too?

pwolanin’s picture

pwolanin commented
StatusFileSize
new 1121170-7006_doc-6.patch968 bytes
pwolanin’s picture

pwolanin commented
Status: Needs review » Fixed

committed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jpmckinney’s picture

jpmckinney commented
Status: Closed (fixed) » Needs review
StatusFileSize
new RemoveMoreVariables.patch619 bytes

Couple more variables missed. Adding as new update hook as people may have already updated since 7006 was written.

jpmckinney’s picture

jpmckinney commented
Title: Remove facet block code in preparation for Facet API integration » Remove facet block code
cpliakas’s picture

cpliakas commented
Issue tags: +Facet API integration

I have another post that is more or less related at #1159172: Remove unused facet functions. It might be good for myself or someone else to roll those patch into this issue.

jpmckinney’s picture

jpmckinney commented
Status: Needs review » Fixed

The two patches don't affect the same parts of the code, so I'm committing this one separately.

Automatically closed -- issue fixed for 2 weeks with no activity.